Fix badly positioned screen with autofocus

[jnowakow]

Explanation of Change

Composer isn't displayed on first render of ReportScreen when navigating to new chat. It renders when there are already components on screen. In such situation Composer has autoFocus set to true which opens keyboard automatically when it renders. But since it's not first render it seems that some calculation breaks on android hybrid app.

Fixed Issues

$ https://github.com/Expensify/App/issues/53185 PROPOSAL: N/A

Tests

1. Click Start new chat.
2. Search for a person that you has no conversation history and hadn't search for in this session
3. Click that person to open chat.
4. Verify that input is focused and there is no blank space between keyboard and input

• [x] Verify that no errors appear in the JS console

Offline tests

Same as in Tests

QA Steps

Same as in Tests

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Hybrid:

https://github.com/user-attachments/assets/e71fad8a-c088-494b-990d-4c67b67fd3b9

ND:

https://github.com/user-attachments/assets/21ab2fd6-20f1-4430-89ee-ab90c68f6530

Android: mWeb Chrome

N/A

iOS: Native

Hybrid:

https://github.com/user-attachments/assets/3746e7c3-2d41-4587-b683-fb0afa9e3451

ND:

https://github.com/user-attachments/assets/a48b3c61-039a-4838-841d-9c5713738f81

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/83a7f0ab-574f-465b-856f-44bc2e57ab4e

MacOS: Desktop

https://github.com/user-attachments/assets/988782c2-92eb-4538-822a-ccde0b56e2a9

[melvin-bot[bot]]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions[bot]]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[mountiny]

@jnowakow Can you please fill in the QA steps too and add videos? You have not added any

@DylanDylann can you please test this one? thanks!

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53699/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53699/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53699/NewExpensify.dmg	https://53699.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[jnowakow]

@mountiny I've updated the comment (I've had problems with running ND on mobile browsers so I'll try to record those videos later)

[DylanDylann]

I can only test on ND, this change looks safe for ND

[DylanDylann]

@jnowakow The app is crashed when going to an invalid report URL

https://github.com/user-attachments/assets/c7dc4aba-425c-468d-827e-7a43456f8c00

[jnowakow]

@DylanDylann please check once more

[github-actions[bot]]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53699/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53699/NewExpensify.dmg	https://53699.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[DylanDylann]

@jnowakow We have a bit of a difference between the main branch when the screen is loading

Main branch

https://github.com/user-attachments/assets/4152295f-bd30-4945-80ee-b8f950a3531c

Current PR

https://github.com/user-attachments/assets/e0aa3b82-f20d-4279-b799-80e47c812597

[jnowakow]

@DylanDylann I can't see the difference. Are you sure you it's not the same recording two times?

[DylanDylann]

Ops, wrong video

[DylanDylann]

@jnowakow I already updated again

[jnowakow]

@DylanDylann yeah, now I see the difference :)

[mountiny]

@jnowakow any update here?

[jnowakow]

@mountiny I worked on it but it's hard to debug. It's caused by focus being called in one of many rerenders and it causes whole screen to go up by the height of the keyboard.

I think I'll try to find some workaround (and maybe clean up a bit ReportScreen)

[jnowakow]

@mountiny @DylanDylann I've pushed new commit with a workaround. I'm not sure why it works this way but it seems like issue with autoFocus and what helps is to delay focus and call it from setTimeout. It's a hack but I wasn't able to find the root cause :( Please check if it works for you

[jnowakow]

btw are you able to reproduce this issue? It happens for me even on ND on main

https://github.com/user-attachments/assets/2dac8d2d-d4ad-4498-b3a9-8df03249bfdb

[DylanDylann]

@jnowakow Could we use useAutoFocusInput hook?

https://github.com/Expensify/App/blob/main/src/hooks/useAutoFocusInput.ts

[jnowakow]

@DylanDylann you're right, I'll use it

[jnowakow]

@DylanDylann updated

[jnowakow]

@mountiny we can test hybrid adhoc builds here. Can you trigger Build and deploy hybird apps for testing workflow on this branch?

[mountiny]

Its not going to be hybrid build, is this also repro in standalone app?

[github-actions[bot]]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53699/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53699/NewExpensify.dmg	https://53699.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[jnowakow]

@mountiny Build and deploy hybrid apps for testing is a new workflow for building adhoc hybrid apps and I wanted to test it here but I see it's to early and I have to fix somethings

[DylanDylann]

@jnowakow We avoid using Platform checking on our codebase. Could you apply this pattern to this PR?

https://github.com/Expensify/App?tab=readme-ov-file#platform-specific-file-extensions

[jnowakow]

@DylanDylann I can see some usages of Platform.OS across the App and I think duplicating file to change one line would be very confusing. But I can see that useAutoFocusInput hook was added to fix Android specific issue so I can check if iOS works correctly without this hook. If yes it would make sense to separate implementation between iOS and Android so it's clear that we handle autoFocus in a different way on both platforms

[mountiny]

What is next for this pr?