Expensify
Add Submit action to Search
We've added the Approve and Pay actions to Search in [this PR](https://github.com/Expensify/App/issues/51911. Next, we should add the Submit action to the Search results page to make it a complete experience for users looking to batch manage their expenses
SubmitReport is currently not 1:1:1 which means this issue depends on migrating this command first. I'm auditing the code to assess what code needs to be migrated to make this feature feasible.
Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.75-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53641
If no regressions arise, payment will be issued on 2024-12-20. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @ishpaul777 requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [x] [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [x] [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon. https://github.com/Expensify/Expensify/issues/455332
Preparing for upcoming payment
Contributor+: @ishpaul777 owed $250 via NewDot
@ishpaul777 do we need a regression test for this?
Payment Summary
Upwork Job
- ROLE: @ishpaul777 paid $250 via Upwork (https://www.upwork.com/nx/wm/workroom/39299132/overview)
BugZero Checklist (@Christinadobrzyn)
- [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- [x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [x] I have verified the payment summary above is correct
@ishpaul777 are you paid in Upwork? https://www.upwork.com/nx/wm/offer/105419289
Do we need a regression test for this? TY!
@ishpaul777 are you paid in Upwork? https://www.upwork.com/nx/wm/offer/105419289
yes Accepted Offer!
Do we need a regression test for this?
I think we should be adding all regression test flow for this feature as part of [Search v1] Add bulk actions on Search project
Can you confirm @luacmartins ?
Just incase not here's Regression test proposet for this issue:
Tests:
- Create a workspace
- Enable workflows and Delay submissions
- Submit an expense to the workspace
- Navigate to the Search page
- Verify that you see the submit button next to the expense
- Press submit
- Verify that the report is submitted
Do we agree 👍 or 👎 ?
I'll create the regression test just in case we want to submit one - https://github.com/Expensify/Expensify/issues/455332
I paid you in Upwork @ishpaul777 based on this payment summary - https://github.com/Expensify/App/issues/53640#issuecomment-2556567337
We'll keep this open to see if @luacmartins has any input on the regression test - https://github.com/Expensify/App/issues/53640#issuecomment-2557744660
📣 @sonkeydotcom! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~0126988bb835c03de3
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Hi @sonkeydotcom! thanks for your interest! This job is already complete. Feel free to check out the open jobs here https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22
I'll close this as complete. @luacmartins is ooo so we'll consider this complete. Thanks everyone!