App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-12-17] Jumpy "Clear filter" button when keyboard gets shown

Open kirillzyusko opened this issue 1 year ago • 5 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.72 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): [email protected] Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kirillzyusko Slack conversation (hyperlinked to channel name):

Action Performed:

  1. Go to search tab
  2. Press workspace switcher
  3. See how additional keyboard space appears (above the keyboard) and disappears
  4. Select workspace
  5. Press workspace switcher
  6. See how button gets moved higher and then return to its expected position

Expected Result:

  1. No jumps
  2. No jumps

Actual Result:

  1. For a fraction of second keyboard spacing exceeds the keyboard and we see a space above the keyboard
  2. Button should be placed in a correct position immediately

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [x] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/5af0a6aa-e91b-4c5f-b5dc-2fd9656943c9

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

kirillzyusko avatar Dec 05 '24 15:12 kirillzyusko

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 05 '24 15:12 melvin-bot[bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Dec 06 '24 10:12 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53635

If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @kirillzyusko does not require payment (Contractor)

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

@youssef-lr @JmillsExpensify @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

melvin-bot[bot] avatar Dec 17 '24 09:12 melvin-bot[bot]

@JmillsExpensify, @youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 20 '24 09:12 melvin-bot[bot]

@JmillsExpensify, @youssef-lr Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

@JmillsExpensify, @youssef-lr Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] avatar Dec 26 '24 09:12 melvin-bot[bot]

I believe the issue has been fixed so it can be closed 🙂

kirillzyusko avatar Dec 26 '24 10:12 kirillzyusko

Hey seems like I never got paid for my review of https://github.com/Expensify/App/pull/53635, could we get this sorted? thanks! @JmillsExpensify

Ollyws avatar Apr 24 '25 16:04 Ollyws

Friendly bump @JmillsExpensify

Ollyws avatar May 09 '25 09:05 Ollyws

Payment Summary

Contributor+: @Ollyws due $250 via NewDot for PR review

I checked assignment date and it's after their eligibility date

mallenexpensify avatar Jul 31 '25 17:07 mallenexpensify

Requested on ND.

Ollyws avatar Jul 31 '25 17:07 Ollyws

@Ollyws has submitted payment for this report on ND here.

SO: https://stackoverflowteams.com/c/expensify/questions/7582

Vendor found in VML: True. Status: Active

Amount requested: $250. Matches the payment summary here.

I am not already the BZ assignee. I have approved this payment.

isabelastisser avatar Aug 05 '25 16:08 isabelastisser