App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Chat - GBR doesn't disappear and new message appears for a deleted IOU

Open lanitochka17 opened this issue 1 year ago • 6 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.71-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Send multiple messages from account A to account B so that there would be a scrollable report
  3. Clear any unread messages from both account A and account B
  4. [Account A] Navigate away from the conversation with account B
  5. {Account B] Send an IOU to account A and delete it once it is received on account A's side
  6. As Account A notice the GBR on LHN
  7. Open the report and notice the new message marker at the top appearing
  8. Notice the subtitle of the LHN

Expected Result:

The GBR gets removed once the IOU is deleted and there will not be a new message button at the top and the LHN subtitle will not show "This chat is with [Username]"

Actual Result:

The GBR doesn't automatically get cleared after IOU has been deleted, upon opening the report the new message button appears at the top and the LHN subtitle shows "This chat is with [username]" even if there is previous chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [x] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/1f91f8cc-71cd-468e-bc29-678bcb55bad8

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021865902022059142383
  • Upwork Job ID: 1865902022059142383
  • Last Price Increase: 2024-12-08
Issue OwnerCurrent Issue Owner: @fedirjh

lanitochka17 avatar Dec 04 '24 17:12 lanitochka17

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 04 '24 17:12 melvin-bot[bot]

@lanitochka17 can you please check those repro steps? As User B I can't delete an IOU at all.

RachCHopkins avatar Dec 06 '24 04:12 RachCHopkins

@RachCHopkins QA team still repro this issue. Can you check please again, maybe you missed that User B deletes the IOU it just created? Build v9.0.72-0

image (7)

https://github.com/user-attachments/assets/5b887db5-7a81-43a7-a51d-030f11f6c46f

izarutskaya avatar Dec 06 '24 16:12 izarutskaya

Thank you @izarutskaya looks like I was missing where the delete button lives now!

RachCHopkins avatar Dec 08 '24 23:12 RachCHopkins

Job added to Upwork: https://www.upwork.com/jobs/~021865902022059142383

melvin-bot[bot] avatar Dec 08 '24 23:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

melvin-bot[bot] avatar Dec 08 '24 23:12 melvin-bot[bot]

@RachCHopkins @fedirjh could this be a backend issue? The "New message" pop up won't disappear because lastVisibleActionCreated isn't updated in the recipient's report. While in the sender's report action it is.

Zakpak0 avatar Dec 09 '24 05:12 Zakpak0

What do you think, @fedirjh - I don't know enough to venture an opinion!

RachCHopkins avatar Dec 12 '24 05:12 RachCHopkins

@RachCHopkins, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 12 '24 09:12 melvin-bot[bot]

I agree with @Zakpak0 , lastVisibleActionCreated is not updated correctly when the IOU is deleted. This is a backend issue.

@RachCHopkins Can you please add the internal label to this one? Thanks

fedirjh avatar Dec 12 '24 15:12 fedirjh

@RachCHopkins, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

@RachCHopkins seems the internal assignment was not triggered.

fedirjh avatar Dec 17 '24 09:12 fedirjh

@fedirjh there is no auto-assignment with the Internal label. We wait for the curator to assign a priority and then an engineer to pick it up. It could take weeks.

RachCHopkins avatar Dec 18 '24 04:12 RachCHopkins

@RachCHopkins @fedirjh this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 18 '24 09:12 melvin-bot[bot]

Still waiting for a volunteer.

RachCHopkins avatar Jan 10 '25 00:01 RachCHopkins

This issue has not been updated in over 15 days. @RachCHopkins, @fedirjh eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Feb 03 '25 09:02 melvin-bot[bot]

Still sitting at a Med priority.

RachCHopkins avatar Mar 05 '25 04:03 RachCHopkins

Low priority.

RachCHopkins avatar Apr 07 '25 22:04 RachCHopkins

Still low priority.

RachCHopkins avatar Apr 16 '25 20:04 RachCHopkins

Closing this, it's been 6 months.

RachCHopkins avatar May 27 '25 02:05 RachCHopkins