App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Android - Domains - When returning from domains, headers in the app overlap notification bar

Open IuliiaHerets opened this issue 1 year ago • 4 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.70-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Tap on "Settings" on the bottom of the screen.
  3. Tap on "Domains"
  4. Once redirected to OD, tap on the hamburger menu and tap on "Try New Expensify"
  5. Once navigated again to ND, verify that the headers in all the sections are correctly displayed, without overlapping the device notification bar.

Expected Result:

When returning from OD, after navigating to Domains, headers in all sections should remain in the same position, without being overlapped by notifications bar of the device.

Actual Result:

After navigating to OD, when tapping on "Domains" and returning to ND, header is moved up and is displayed overlapped by the device notifications bar. This is visible in every section of the app, after returning.

Workaround:

Unknown

Platforms:

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/8c98560b-839b-46b7-bbd1-1e57a91800c2

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864721405539023301
  • Upwork Job ID: 1864721405539023301
  • Last Price Increase: 2024-12-05
Issue OwnerCurrent Issue Owner: @allroundexperts

IuliiaHerets avatar Dec 04 '24 08:12 IuliiaHerets

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 04 '24 08:12 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864721405539023301

melvin-bot[bot] avatar Dec 05 '24 17:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

melvin-bot[bot] avatar Dec 05 '24 17:12 melvin-bot[bot]

This should be Internal as the video shows Android HybridApp where the Domains link opens within the HybridApp in a web view - External contributors don't have access to the HybridApp repo.

Also it's impossible to reproduce and test the issue on Android: Native since the Domains link opens externally in the web browser, which is why I don't even think this issue exist on Android: Native.

ikevin127 avatar Dec 08 '24 02:12 ikevin127

@allroundexperts, @lschurr Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 09 '24 09:12 melvin-bot[bot]

Changed the labels around - I'll ask for a volunteer in Slack

lschurr avatar Dec 09 '24 16:12 lschurr

Asking here: https://expensify.slack.com/archives/C01SKUP7QR0/p1734018982340219

lschurr avatar Dec 12 '24 15:12 lschurr

@allroundexperts, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

No response in Slack yet: https://expensify.slack.com/archives/C07HPDRELLD/p1734020160697769

lschurr avatar Dec 16 '24 17:12 lschurr

@allroundexperts @lschurr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 18 '24 09:12 melvin-bot[bot]

The video shows it happening on standalone so not sure I agree it’s exclusive to HybridApp, how did you determine that @ikevin127 ?

AndrewGable avatar Dec 19 '24 19:12 AndrewGable

Ah - Apologies I missed the first part of the video. Agree this seems like a HybridApp only bug, but it seems like this is a deep link bug. We reverted deep links here: https://github.com/Expensify/Mobile-Expensify/pull/13336

So this shouldn't be reproducible anymore, and I cannot reproduce on the latest staging version of Android HybridApp.

https://github.com/user-attachments/assets/f3c7cca2-bb04-4247-8cbd-4da4f16ff763

cc @war-in - Please add this to your test steps when we undo the revert.

Please reopen if you disagree.

AndrewGable avatar Dec 19 '24 19:12 AndrewGable

Sure, I'll keep that in mind 🫡

war-in avatar Dec 20 '24 09:12 war-in