App icon indicating copy to clipboard operation
App copied to clipboard

Editing card feed name doesn't work on mobile

Open m-natarajan opened this issue 1 year ago • 9 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

Prerequisite: User added a company card

  1. Click settings for the added card
  2. Click on the Card feed name
  3. Enter any name and save
  4. Click the back arrow two times to view the company cards page

Expected Result:

Entered name updated in the card feed name

Actual Result:

Updated name not saved and default card name displayed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [x] iOS: Standalone
  • [x] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/e96c0ae9-beaf-4595-97de-1277d00147fa

View all open jobs on GitHub

m-natarajan avatar Dec 04 '24 03:12 m-natarajan

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 04 '24 03:12 melvin-bot[bot]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash avatar Dec 04 '24 07:12 VickyStash

I've tried with several feeds and wasn't able to reproduce the bug. Asked for more details in the slack.

VickyStash avatar Dec 04 '24 08:12 VickyStash

Contributor Plus of Company Feed Feature - I'd love to take this issue with VickyStash

DylanDylann avatar Dec 04 '24 09:12 DylanDylann

Updates: It looks like it's a back-end issue. After feed name update the OpenPolicyCompanyCardsPage API call returns companyCardNicknames in the format:

 "companyCardNicknames": {
         "oauth": {
              "wellsfargo": {
                   "com": "test"
               }
          }
},

while app expects it to be

"companyCardNicknames": {
    "oauth.wellsfargo.com": "test"
}

The discussion is in the slack.

VickyStash avatar Dec 04 '24 15:12 VickyStash

I believe this should fix it

  • https://github.com/Expensify/Auth/pull/13450

cc @nkuoch and @mountiny who are on it.

mallenexpensify avatar Dec 06 '24 01:12 mallenexpensify

https://github.com/Expensify/Auth/pull/13450

I think it got merged by @mountiny!

VickyStash avatar Dec 06 '24 15:12 VickyStash

Yep, merged this morning

joekaufmanexpensify avatar Dec 06 '24 15:12 joekaufmanexpensify

@joekaufmanexpensify @mountiny Should this one be closed?

VickyStash avatar Dec 09 '24 22:12 VickyStash

Yes, this is fixed

mountiny avatar Dec 10 '24 12:12 mountiny