App icon indicating copy to clipboard operation
App copied to clipboard

Connecting Wells Fargo direct feed not working correctly on mobile. You land on the sign in page after connecting

Open m-natarajan opened this issue 1 year ago • 6 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

  1. Enable company card in workspace
  2. Click Add card and choose Wells forgo bank
  3. Enter credentials and click connect

Expected Result:

User redirected to the feed page

Actual Result:

User redirected to sign in page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [x] iOS: Standalone
  • [x] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/755c6fb9-b6f2-49ee-bdee-396fe865ca6f

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VickyStash

m-natarajan avatar Dec 04 '24 02:12 m-natarajan

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 04 '24 02:12 melvin-bot[bot]

@joekaufmanexpensify I am not able to see any difference in how wells fargo would handle this compared to other banks. Can you please confirm you can only reproduce this for this bank and not for others on mobile?

mountiny avatar Dec 06 '24 14:12 mountiny

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash avatar Dec 10 '24 09:12 VickyStash

@abekkala, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

It's not overdue, we are actively discussing it in slack.

VickyStash avatar Dec 10 '24 09:12 VickyStash

I've prepared a test PR with additional logs and added a note how it can be used.

VickyStash avatar Dec 10 '24 12:12 VickyStash

It seems to be API-related, caused by pusher updates raised last week see more details in the slack.

VickyStash avatar Dec 10 '24 14:12 VickyStash

We figured out that the issue here is we intentionally disabled onyx updates for the webview temporarily as part of a performance issue. As soon as they're re-enabled, this issue should be resolved.

Closing this for now as we shouldn't need to do anything here. I'll just retest this once onyx updates are re-enabled!

joekaufmanexpensify avatar Dec 10 '24 16:12 joekaufmanexpensify

Reopening this as the modal is not autoclosing on mobile now

mountiny avatar Jan 07 '25 11:01 mountiny

Updates:

  • I wasn't able to reproduce the issue with Amex bank. Waiting for more details/ clarification on reproduction steps - discussed in the slack.

VickyStash avatar Jan 07 '25 19:01 VickyStash

Updates:

  • According to the Slack discussion I'll try to add a loading indication to the bank connection flow in the moment when the app is waiting for the new feed data to be received.

VickyStash avatar Jan 08 '25 15:01 VickyStash

Updates: I've opened the PR for the review! I wasn't able to test the updates over all of the platforms due to reasons described here: https://github.com/Expensify/App/pull/54999#issuecomment-2580763663

VickyStash avatar Jan 09 '25 16:01 VickyStash

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Jan 15 '25 13:01 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.85-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/54999

If no regressions arise, payment will be issued on 2025-01-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @VickyStash does not require payment (Contractor)

melvin-bot[bot] avatar Jan 15 '25 13:01 melvin-bot[bot]

@mountiny @abekkala @VickyStash The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Jan 15 '25 13:01 melvin-bot[bot]

Nothing to pay here and no need for specific regression test, this is still new feature

mountiny avatar Jan 15 '25 14:01 mountiny