App Add report action for deleting expenses off of processing reports

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: N/A Reproducible in staging?: N/A Reproducible in production?: N/A If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: None Issue reported by: @sakluger Slack conversation (hyperlinked to channel name): It's in eng, but it's more #expense

Action Performed:

Create new workspace (Instant Submit will be enabled by default)
Enable Approvals
Invite Submitter A
Have Submitter A create an expense
Have Submitter A delete the expense

Expected Result:

When we make a change to an expense on a processing report, we add a report action indicating the change. We'd expect to see something like:

User Name deleted an expense on this report, [Merchant] - [Amount]

If it was me deleting it, it'd look like this:

Garrett Knight deleted an expense on this report, Nando's - £12.77

Actual Result:

The expense is deleted without a trace, confusing approvers when they've seen that an expense was once on the report.

Workaround:

None

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Dec 03 '24 17:12 garrettmknight

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Dec 03 '24 17:12 melvin-bot[bot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense is deleted without a trace, confusing approvers when they've seen that an expense was once on the report.

What is the root cause of that problem?

When we delete a money request, we don't add any report action to keep track of the change

What changes do you think we should make in order to solve the problem?

Define a new report action for delete expense like DELETE_EXPENSE
In deleteMoneyRequest, create an optimistic action, remove pendingAction in sucessData, and add an error in failureData in the expense report if shouldDeleteIOUReport is false and the report is a processing report. This action will have some data in originalMessage like amount, merchant, currency

https://github.com/Expensify/App/blob/ce282d38777e9e0a267e1b6f44bff9c4aace98ee/src/libs/actions/IOU.ts#L5735

Add the deleteExpenseReportActionID param as the reportActionID of the optimistic action above here

https://github.com/Expensify/App/blob/ce282d38777e9e0a267e1b6f44bff9c4aace98ee/src/libs/actions/IOU.ts#L5962

Define a function to get the translation for the action and

Add a case for this action here for the alternative text in LHN
Add a case in ReportActionItem here for the action in ReportScreen
Add a case in getReportName function here for thread header translation
Add a case in here for the copy message

Require backend change

Introduce a new param in DeleteMoneyRequest API like deleteExpenseReportActionID and use this ID to generate a new delete expense action and return it to front end.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can define a new test case in IOUTest here. We need to create mock data accordingly and verify a new delete expense action is created in this case when we call DeleteMoneyRequest API.

https://github.com/Expensify/App/blob/ce282d38777e9e0a267e1b6f44bff9c4aace98ee/tests/actions/IOUTest.ts#L1910

What alternative solutions did you explore? (Optional)

NA

Dec 04 '24 05:12 nkdengineer

@youssef-lr, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

Dec 09 '24 09:12 melvin-bot[bot]

hey @youssef-lr are you working on this one, or should we be assigning external for them to review the proposal above? Thanks!

Dec 10 '24 12:12 zanyrenney

@zanyrenney I should have the backend PRs ready today, but we can also assign someone to work on the frontend PRs. @nkdengineer's proposal LGTM, except that we should only record this action if the report is PROCESSING.

Dec 10 '24 12:12 youssef-lr

Made some progress locally and should have the first Auth PR ready by EOD

Dec 12 '24 01:12 youssef-lr

great update, thank you so much @youssef-lr !

Dec 12 '24 17:12 zanyrenney

Job added to Upwork: https://www.upwork.com/jobs/~021867259873329835185