App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-12-17] [$250] Android - Report auto closes when opening WS settings via deep link and returning to chat

Open IuliiaHerets opened this issue 1 year ago β€’ 12 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Create a new workspace.
  3. Go to workspace settings > More features.
  4. Enable Report fields and upgrade to Control plan.
  5. Close and reopen the app (important).
  6. Open workspace switcher and select the upgraded Control workspace.
  7. Go to #admins.
  8. Tap "here" link in the whisper message.
  9. Tap app back button three times.

Expected Result:

App will return to #admins (production behavior).

Actual Result:

Describe what actually happenedApp returns to #admins, then it auto navigates to LHN with workspace filter cleared. On iOS, it directly opens LHN with workspace filter cleared.

Workaround:

Unknown

Platforms:

  • [x ] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [x] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/16198424-b6e4-40b4-a16c-a648dcdf0f5f

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863543484433627612
  • Upwork Job ID: 1863543484433627612
  • Last Price Increase: 2024-12-02
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 105156060
Issue OwnerCurrent Issue Owner: @sonialiap

IuliiaHerets avatar Dec 02 '24 11:12 IuliiaHerets

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 02 '24 11:12 melvin-bot[bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Dec 02 '24 11:12 melvin-bot[bot]

πŸ’¬ A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Dec 02 '24 11:12 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Dec 02 '24 11:12 github-actions[bot]

Looks like a navigation issue. But it's not a breaking bug and does not have a very huge impact on the user experience. Demoting from a deploy blocker but let's investigate and fix!

MariaHCD avatar Dec 02 '24 11:12 MariaHCD

Job added to Upwork: https://www.upwork.com/jobs/~021863543484433627612

melvin-bot[bot] avatar Dec 02 '24 11:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

melvin-bot[bot] avatar Dec 02 '24 11:12 melvin-bot[bot]

@mountiny I will take a look at this one

adamgrzybowski avatar Dec 02 '24 11:12 adamgrzybowski

πŸ“£ @ZhenjaHorbach πŸŽ‰ An offer has been automatically sent to your Upwork account for the Reviewer role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Dec 02 '24 11:12 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53576

If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @adamgrzybowski does not require payment (Contractor)
  • @ZhenjaHorbach requires payment automatic offer (Reviewer)

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

@ZhenjaHorbach @sonialiap @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 13 '24 11:12 melvin-bot[bot]

I'm OOO Dec 16-20, adding a leave buddy

next steps:

  • make payments on the 17th
  • complete checklist

sonialiap avatar Dec 13 '24 11:12 sonialiap

BugZero Checklist:

  • [x] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [ ] 1a. Result of the original design (eg. a case wasn't considered)
  • [x] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [x] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • [ ] 2b. Reported on staging (eg. found during regression or PR testing)
  • [ ] 2d. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [ ] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [x] 3d. QA
  • [ ] 3z. Other:
  • [x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

https://github.com/Expensify/App/pull/40016/files#r1889116316

  • [x] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    NA

  • [x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [x] BZ add regression test

    • https://github.com/Expensify/Expensify/issues/455571

Regression Test Proposal

  1. Launch App
  2. Create a new workspace
  3. Go to workspace settings > More features
  4. Enable Report fields and upgrade to Control plan
  5. Close and reopen the app (important)
  6. Open workspace switcher and select the upgraded Control workspace
  7. Go to #admins
  8. Tap "here" link in the whisper message
  9. Tap app back button three times
  10. Verify that the app will return to #admins

Do we agree πŸ‘ or πŸ‘Ž

ZhenjaHorbach avatar Dec 17 '24 19:12 ZhenjaHorbach

@sonialiap, @mallenexpensify, @mountiny, @adamgrzybowski, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 20 '24 09:12 melvin-bot[bot]

Not overdue We are waiting for payment

ZhenjaHorbach avatar Dec 20 '24 09:12 ZhenjaHorbach

Contributor+: @ZhenjaHorbach paid $250 via Upwork

@ZhenjaHorbach , apologies for the delay. Can you propose regression test steps? I want to create a test case, in case QA wants to add or update one. Thx

mallenexpensify avatar Dec 21 '24 13:12 mallenexpensify

Contributor+: @ZhenjaHorbach paid $250 via Upwork

@ZhenjaHorbach , apologies for the delay. Can you propose regression test steps? I want to create a test case, in case QA wants to add or update one. Thx

Thanks for payment ! I have updated Bugzero checklist and included regression test steps

ZhenjaHorbach avatar Dec 21 '24 13:12 ZhenjaHorbach

Thanks Matt and Zhenja!

Added regression test update. Closing out

sonialiap avatar Dec 23 '24 13:12 sonialiap