Expensify
[HOLD for payment 2024-12-17] [$250] iOS - Attachment - No sliding in animation when opening attachment
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team
Action Performed:
- Launch ND or hybrid app.
- Go to DM.
- Tap on the chat header.
- Tap on the user avatar.
- Note that there is no sliding in animation when opening avatar.
- Submit an expense with a receipt.
- Send an image to the chat.
- Open the receipt from the expense.
- Open the image attachment.
Expected Result:
There will be sliding in animation when opening attachment (production behavior).
Actual Result:
There is no sliding in animation when opening attachment. The app blinks slightly when the attachment is opened.
Workaround:
Unknown
Platforms:
- [ ] Android: Standalone
- [ ] Android: HybridApp
- [ ] Android: mWeb Chrome
- [x] iOS: Standalone
- [x] iOS: HybridApp
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/01669cc4-aeab-42b4-bbcb-b9835be86f19
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021863486574634374199
- Upwork Job ID: 1863486574634374199
- Last Price Increase: 2024-12-02
- Automatic offers:
- ikevin127 | Reviewer | 105182252
Issue Owner
Current Issue Owner: @Christinadobrzyn
Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thai must be coming from the native stack change
@chrispader @hannojg @kirillzyusko for eyes
I dont think this is a blocker as users can open and view the attachment fine, teated on ios too
Job added to Upwork: https://www.upwork.com/jobs/~021863486574634374199
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)
Catching up here - I think we're waiting on proposals, is that right @ikevin127?
Yes, unless somebody from our expert agencies wants to handle this - we're open for proposals based on the context mentioned in https://github.com/Expensify/App/issues/53362#issuecomment-2510775039.
This was scheduled to @chrispader who already started looking into it, can you pls comment @chrispader. Thanks!
I've created a PR with a fix for this specific issue here: https://github.com/Expensify/App/pull/53475
This fix is a hacky workaround tbh, since we're basically just delaying the navigation by 200ms.
The problem we see in this issue is the same as previous problems we had with RN modals/react-native-modals in the NativeStack PR. When modals are mounted/opened on a new screen - essentially at the same the time the screen mounts - the slide in animation will not be visible. Same thing for unmounting a modal. If the modal is hidden/unmounted at the same time as we navigate back from a screen, the animation cannot be seen.
This should ultimately by fixed with a more holistic solution, where we replace all legacy modals with modal (screens) from @react-navigation, though i think this should be handled in a separate PR.
For example in this issue, the problem is with the AttachmentModal component used in ProfileAvatar. It is used in many places. Same thing goes for other screens, that are essentially just modals. This won't work with NativeStack.
📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Thanks @chrispader - I added you to this GH. @mountiny and @ikevin127 does this solution sound good? https://github.com/Expensify/App/issues/53362#issuecomment-2514954175
Yes, we're already working on the PR - should be merged today or tomorrow!
PR here - https://github.com/Expensify/App/pull/53475
moving this to weekly while the PR is worked on.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
PR was reverted as it had 2 regressions, we're probably looking at a re-work. No compensation required since the PR was reverted.
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53475
If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @chrispader does not require payment (Contractor)
- @ikevin127 requires payment automatic offer (Reviewer)
@ikevin127 @Christinadobrzyn @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Looks like we're ready for payment but I don't see anything about a regression test.
@ikevin127 do we need a regression test for this?
Contributor+: @ikevin127 owed $250 via Upwork (https://www.upwork.com/nx/wm/offer/105182252)
PR was reverted as it had 2 regressions, we're probably looking at a re-work. No compensation required since the PR was reverted.
@Christinadobrzyn No payment required here as the PR was reverted. Not sure where we are with the issue, maybe @chrispader has more context on what happened after the revert regarding the issue.
Ah thank you @ikevin127 - really appreciate the clarity. @chrispader can you let us know your thoughts on next steps?
@chrispader, @mountiny, @Christinadobrzyn, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?
I think this still has to be handled, gonna make it weekly over the holidays
This issue would get fixed by https://github.com/Expensify/App/issues/53493, so i'm going to further push forward the modal migration solution
@chrispader @mountiny @Christinadobrzyn @ikevin127 this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
Thanks for the update @chrispader! We'll add a HOLD to this and monitor - https://github.com/Expensify/App/issues/53493
(or let me know if there's a better course of action). TY!