App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-12-11] [HOLD for payment 2024-12-09] [$250] Android - Tapping save works only after multiple taps in workspace profile name page

Open IuliiaHerets opened this issue 1 year ago β€’ 19 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9. 0.69-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. Go to workspace settings
  3. Tap profile
  4. Rename name field
  5. Tap save

Expected Result:

On tapping save, new workspace name must be saved.

Actual Result:

Tapping save works only after multiple taps in workspace profile name page.

Workaround:

Unknown

Platforms:

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/95d0d7dc-6ae9-43b0-9baf-8bc5f246da6a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863283611435594958
  • Upwork Job ID: 1863283611435594958
  • Last Price Increase: 2024-12-01
  • Automatic offers:
    • ikevin127 | Reviewer | 105158811
    • shubham1206agra | Contributor | 105162432
Issue OwnerCurrent Issue Owner: @MitchExpensify

IuliiaHerets avatar Dec 01 '24 10:12 IuliiaHerets

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 01 '24 10:12 melvin-bot[bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Dec 01 '24 10:12 melvin-bot[bot]

πŸ’¬ A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Dec 01 '24 10:12 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Dec 01 '24 10:12 github-actions[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863283611435594958

melvin-bot[bot] avatar Dec 01 '24 18:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

melvin-bot[bot] avatar Dec 01 '24 18:12 melvin-bot[bot]

@mountiny Hey, I'm Kiryl from Margelo expert agency and I'd liek to work on this issue πŸ‘€

kirillzyusko avatar Dec 02 '24 11:12 kirillzyusko

πŸ“£ @ikevin127 πŸŽ‰ An offer has been automatically sent to your Upwork account for the Reviewer role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Dec 02 '24 15:12 melvin-bot[bot]

@mountiny Please assign me here.

shubham1206agra avatar Dec 02 '24 16:12 shubham1206agra

πŸ“£ @shubham1206agra πŸŽ‰ An offer has been automatically sent to your Upwork account for the Contributor role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review πŸ§‘β€πŸ’» Keep in mind: Code of Conduct | Contributing πŸ“–

melvin-bot[bot] avatar Dec 02 '24 18:12 melvin-bot[bot]

Applause confirmed it is fixed after the CP.

puneetlath avatar Dec 02 '24 18:12 puneetlath

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 02 '24 21:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.69-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53384

If no regressions arise, payment will be issued on 2024-12-09. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @kirillzyusko does not require payment (Contractor)
  • @shubham1206agra requires payment automatic offer (Contributor)

melvin-bot[bot] avatar Dec 02 '24 21:12 melvin-bot[bot]

@shubham1206agra @MitchExpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 02 '24 21:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.70-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53384

If no regressions arise, payment will be issued on 2024-12-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @kirillzyusko does not require payment (Contractor)
  • @shubham1206agra requires payment automatic offer (Contributor)

melvin-bot[bot] avatar Dec 04 '24 01:12 melvin-bot[bot]

@shubham1206agra @MitchExpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 04 '24 01:12 melvin-bot[bot]

BugZero Checklist:

  • [ ] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [ ] 1a. Result of the original design (eg. a case wasn't considered)
  • [ ] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • [ ] 2b. Reported on staging (eg. found during regression or PR testing)
  • [ ] 2d. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [ ] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [ ] 3d. QA
  • [ ] 3z. Other:
  • [ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment:

  • [ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template
  • [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree πŸ‘ or πŸ‘Ž

MitchExpensify avatar Dec 05 '24 01:12 MitchExpensify

Here's the BZ checklist as a next step @shubham1206agra, thanks

MitchExpensify avatar Dec 05 '24 01:12 MitchExpensify

Reminder on the BZ steps above before payment @shubham1206agra

MitchExpensify avatar Dec 10 '24 01:12 MitchExpensify

@kirillzyusko, @mountiny, @MitchExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 13 '24 09:12 melvin-bot[bot]

BugZero Checklist:

  • [x] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [ ] 1a. Result of the original design (eg. a case wasn't considered)
  • [x] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • [x] 2b. Reported on staging (eg. found during regression or PR testing)
  • [ ] 2d. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [ ] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [x] 3d. QA
  • [ ] 3z. Other:
  • [x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/52392/files#r1884142722

  • [x] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: Not Required

  • [x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

No tests required as this is a deploy blocker and already present in test suite.

Do we agree πŸ‘ or πŸ‘Ž

shubham1206agra avatar Dec 13 '24 15:12 shubham1206agra

Paid and contract ended, all set here

MitchExpensify avatar Dec 16 '24 13:12 MitchExpensify