App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Android - Expense - App crashes when exchanging expenses offline and returning online

Open IuliiaHerets opened this issue 1 year ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5284437 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • User A and User B have never chatted before.
  1. Launch ND or hybrid app.
  2. [User A (Android)] Go offline
  3. [User A (Android)] Go to FAB > Submit expense > Submit a manual expense to User B
  4. [User A (Android)] Remain in main chat with User B.
  5. [User B (any device)] While online, submit an expense of the same amount to User A
  6. [User A (Android)] Go online while stay in main chat with User B (important).

Expected Result:

App will not crash for User A after returning online and app updates.

Actual Result:

App crashes for User A after returning online and app updates.

Workaround:

Unknown

Platforms:

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

0112.txt

https://github.com/user-attachments/assets/14a0a684-8cb3-4f05-8fa7-0b99e4ad7a99

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863283299981466432
  • Upwork Job ID: 1863283299981466432
  • Last Price Increase: 2024-12-08
Issue OwnerCurrent Issue Owner: @allgandalf

IuliiaHerets avatar Dec 01 '24 10:12 IuliiaHerets

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Dec 01 '24 10:12 melvin-bot[bot]

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Dec 01 '24 10:12 melvin-bot[bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 01 '24 10:12 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Dec 01 '24 10:12 github-actions[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863283299981466432

melvin-bot[bot] avatar Dec 01 '24 18:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

melvin-bot[bot] avatar Dec 01 '24 18:12 melvin-bot[bot]

Does this not happen on other platforms?

What does the console show when the crash happens

mountiny avatar Dec 01 '24 18:12 mountiny

Didn't crash on iOS but the total amount is 0 in report preview:

Screenshot 2024-12-02 at 12 16 06 AM Screenshot 2024-12-02 at 12 16 09 AM

allgandalf avatar Dec 01 '24 18:12 allgandalf

@allgandalf did you get some console error on web?

mountiny avatar Dec 02 '24 07:12 mountiny

didn't look, will test again

allgandalf avatar Dec 02 '24 07:12 allgandalf

The bug report is for Android, not iOS.

puneetlath avatar Dec 02 '24 16:12 puneetlath

The bug report is for Android, not iOS.

Ik ik , I was testing if it is reproducible as @mountiny was asking here 😅

allgandalf avatar Dec 02 '24 16:12 allgandalf

@allgandalf did you get some console error on web?

No error console error on web!

allgandalf avatar Dec 02 '24 19:12 allgandalf

Decided to demote based on discussion in this thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1733047965445649

puneetlath avatar Dec 02 '24 21:12 puneetlath

waiting for proposals

allgandalf avatar Dec 05 '24 13:12 allgandalf

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 08 '24 16:12 melvin-bot[bot]

@JmillsExpensify, @youssef-lr, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 09 '24 09:12 melvin-bot[bot]

Still waiting for proposals

JmillsExpensify avatar Dec 11 '24 08:12 JmillsExpensify

@JmillsExpensify, @youssef-lr, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 11 '24 09:12 melvin-bot[bot]

waiting for proposals

allgandalf avatar Dec 11 '24 12:12 allgandalf

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 14 '24 05:12 mvtglobally

@JmillsExpensify @youssef-lr @allgandalf this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 15 '24 09:12 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 15 '24 16:12 melvin-bot[bot]

Lets close this then!

allgandalf avatar Dec 15 '24 16:12 allgandalf

@JmillsExpensify, @youssef-lr, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 19 '24 09:12 melvin-bot[bot]

Issue not reproducible during KI retests. (Second week)

mvtglobally avatar Dec 21 '24 02:12 mvtglobally

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 22 '24 16:12 melvin-bot[bot]

please close the issue, this is not reproducible

allgandalf avatar Dec 23 '24 05:12 allgandalf

@JmillsExpensify, @youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 26 '24 09:12 melvin-bot[bot]

@JmillsExpensify @youssef-lr this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Dec 29 '24 09:12 melvin-bot[bot]