App icon indicating copy to clipboard operation
App copied to clipboard

[$125] iOS Navigation - Inbox, Search and Settings open in slow-motion

Open IuliiaHerets opened this issue 1 year ago β€’ 24 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Launch ND or hybrid app.
  2. Navigate between Inbox, Search and Settings.

Expected Result:

Inbox, Search and Settings will open without slow-motion.

Actual Result:

Inbox, Search and Settings open in slow-motion.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [x] iOS: Standalone
  • [x] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/edd5533d-462e-4ab4-b47a-9ef1f3b9f783

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021865056809629169420
  • Upwork Job ID: 1865056809629169420
  • Last Price Increase: 2024-12-06
Issue OwnerCurrent Issue Owner: @DylanDylann

IuliiaHerets avatar Nov 30 '24 21:11 IuliiaHerets

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 30 '24 21:11 melvin-bot[bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Nov 30 '24 21:11 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Nov 30 '24 21:11 github-actions[bot]

πŸ’¬ A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Nov 30 '24 21:11 melvin-bot[bot]

This was a change by design as we switched to native stack and i dont think its blocking deploy.

I believe design team did not have any objections but could you please weigh in again (it has been a while it has been discussed on the pr) cc @Expensify/design

mountiny avatar Dec 01 '24 08:12 mountiny

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

melvin-bot[bot] avatar Dec 01 '24 08:12 melvin-bot[bot]

I can't test this as I can't pull this version yet, but I don't mind the fade between the screens. I'd personally speed up the fade animation a tad cause when navigating quickly between the tabs it can often cause issues or feel slow if it's not snappy enough. I'm happy to do that as a follow-up bug though.

Keen to hear what rest of @Expensify/design thinks here

dubielzyk-expensify avatar Dec 01 '24 23:12 dubielzyk-expensify

I am +1 to making this making twice the speed

mountiny avatar Dec 02 '24 09:12 mountiny

Same, agree with you both. πŸ‘

trjExpensify avatar Dec 02 '24 11:12 trjExpensify

Just experienced this for the first time today and I agree, the fade felt a little weird at first, but then I think I got used to it and it felt nice. Either way, I agree that speeding it up a bit will make it feel less "broken" and more expected.

shawnborton avatar Dec 02 '24 13:12 shawnborton

Agree with all of the above, let's send it!

dannymcclain avatar Dec 02 '24 14:12 dannymcclain

Would also be good if we could somehow test this on some slower devices and slower internet just to make sure that it still works well.

I'm testing this in prod on my iPhone 15 Pro and while speeding up the animation will help, there also seem to be a massive delay when I tap the bottom nav to when it turns to active state. Even before the animation kicks in.

dubielzyk-expensify avatar Dec 03 '24 04:12 dubielzyk-expensify

there also seem to be a massive delay when I tap the bottom nav to when it turns to active state

Can you show a video? I dont see any significant delay on my side in ios

mountiny avatar Dec 03 '24 12:12 mountiny

Compared to other apps it seems quite a bit slower and less responsive:

https://github.com/user-attachments/assets/0157e30a-cc7c-4df4-8091-53bfa9cc5465

dubielzyk-expensify avatar Dec 04 '24 03:12 dubielzyk-expensify

@chrispader @kirillzyusko, could you please prepare a PR with half the animation time, and we could iterate on this? I assume the animation just adds up to the slower feeling.

mountiny avatar Dec 04 '24 12:12 mountiny

Compared to other apps it seems quite a bit slower and less responsive:

I just got this version on my phone yesterday and it does feel slower/less responsive to me too. But I don't think it's just the screen animation (which I agree we should speed up)β€”you can see in Jon's video that there's a delay in the tab highlight after he presses as well. IMO it is ok if the bottom tab highlight and screen animation are not in sync. I think the tab should highlight immediately upon pressing to give the user that feedback.

dannymcclain avatar Dec 04 '24 14:12 dannymcclain

Exactly. I'm happy to start with speeding up, but it's pretty clear that there's a delay from the tap before the animation triggers

dubielzyk-expensify avatar Dec 05 '24 00:12 dubielzyk-expensify

Job added to Upwork: https://www.upwork.com/jobs/~021865056809629169420

melvin-bot[bot] avatar Dec 06 '24 15:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

melvin-bot[bot] avatar Dec 06 '24 15:12 melvin-bot[bot]

Making this external as it can be handled by contributors. Can you please speed up the animation by switching between the bottom tabs to twice the speed? Thanks!

mountiny avatar Dec 06 '24 15:12 mountiny

Upwork job price has been updated to $125

melvin-bot[bot] avatar Dec 06 '24 15:12 melvin-bot[bot]

Hey, I'm Kiryl from Margelo expert agency and I'd like to work on this issue πŸ‘‹

I think the tab should highlight immediately upon pressing to give the user that feedback.

You are right, but I think it's only Search tab that doesn't switch immediately, right? Inbox/Settings switch happens almost immediately. When I debugged Search page it had some slow re-renders, so I think it's causing this πŸ˜”

kirillzyusko avatar Dec 09 '24 10:12 kirillzyusko

We could look into the re-renders separately for sure

mountiny avatar Dec 09 '24 11:12 mountiny

We could look into the re-renders separately for sure

Yes, it would be better to create a separate issue for that πŸ™

kirillzyusko avatar Dec 09 '24 13:12 kirillzyusko

Asked here https://expensify.slack.com/archives/C05LX9D6E07/p1733757346965449

mountiny avatar Dec 09 '24 15:12 mountiny

FYI @kirillzyusko take a look at the most recent PR from me: https://github.com/Expensify/App/pull/53198 I hoped it would speed things up a bit, I had to move a bunch of code to another component, but tried to wrap everything I can in useMemo/useCallback.

Kicu avatar Dec 09 '24 15:12 Kicu

@mountiny I've created a new task to investigate slow rerenders https://github.com/Expensify/App/issues/53818

zirgulis avatar Dec 10 '24 09:12 zirgulis

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 21 '24 02:12 mvtglobally

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 26 '24 20:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.78-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53754

If no regressions arise, payment will be issued on 2025-01-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @DylanDylann requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Dec 26 '24 20:12 melvin-bot[bot]