[$250] Profile - Display name field displays live mark down when entering text with mark down

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.69-1 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Profile.
3. Click Display name.
4. Enter text with mark down in name field.

Expected Result:

The name field should not display live mark down because mark down is not supported for display name.

Actual Result:

The name field displays live mark down when entering text with mark down.

Workaround:

Unknown

Platforms:

• [x] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/d14ef106-7616-40b8-827e-c27878b53f40

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866565523965770181
• Upwork Job ID: 1866565523965770181
• Last Price Increase: 2024-12-10

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot[bot]]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ghost]

Edited by proposal-police: This proposal was edited at 2024-11-30 19:38:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Display name field displays live mark down when entering text with mark down

What is the root cause of that problem?

We pass isMarkdownEnabled as true in first name input and last name input

https://github.com/Expensify/App/blob/3cc88f5a83a979c5e588e01065083a3d714e69da/src/pages/settings/Profile/DisplayNamePage.tsx#L92-L101

What changes do you think we should make in order to solve the problem?

We can remove isMarkdownEnabled props in first name input and last name input

https://github.com/Expensify/App/blob/3cc88f5a83a979c5e588e01065083a3d714e69da/src/pages/settings/Profile/DisplayNamePage.tsx#L92-L101

We can check if other inputs have the same problem and fix them

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021866565523965770181

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[alitoshmatov]

Straightforward fix, we can go with @Themoonalsofall 's proposal

C+ reviewed 🎀 👀 🎀

[melvin-bot[bot]]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @Themoonalsofall You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[ghost]

@anmurali @alitoshmatov we have PR https://github.com/Expensify/App/pull/53903 but it is closed because this bug is fixed in this other PR https://github.com/Expensify/App/pull/54293. Should we process payment here?

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @yuwenmemon, @anmurali, @alitoshmatov, @Themoonalsofall eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[alitoshmatov]

Yes based on C+ doc I think we should process payment since PR was created and already reviewed by me before finding out duplicate PR.

cc: @anmurali @yuwenmemon

[ghost]

@anmurali bump here

[ghost]

@alitoshmatov can you bump @anmurali on slack? i requested to join slack but there is a problem so i can't join yet.

[ghost]

@alitoshmatov @anmurali could you please take a look this one? Thanks!

[ghost]

@anmurali @yuwenmemon could you please take a look this comment? Many thanks.

[melvin-bot[bot]]

@yuwenmemon, @anmurali, @alitoshmatov, @Themoonalsofall, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[ghost]

@mallenexpensify Can you help me with this? i am not approved to join slack yet so i can't ping them via slack. Sorry for the inconvenience 🙏

[mallenexpensify]

@Themoonalsofall can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~021899587207378176091

Apologies for the mix up here.

[ghost]

thanks @mallenexpensify, i accepted

[alitoshmatov]

@alitoshmatov @anmurali could you please take a look this one? Thanks!

@Themoonalsofall I did try to catch some eyes couple of times. Just saying so that you don't think I ignored the your messages 😅

[mallenexpensify]

Contributor: @Themoonalsofall paid $250 via Upwork Contributor+: @alitoshmatov due $250 via NewDot

Apologies again, this was an edge case and shouldn't happen again. Thanks for posting the pings in #contributor-plus Ali, sorry I missed those.

[JmillsExpensify]

$250 approved for @alitoshmatov