App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Sign in - OpenApp request is sent every login

Open lanitochka17 opened this issue 1 year ago • 8 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:(https://github.com/Expensify/App/issues/50076) Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Open the DevTools (3 dots -> More tools -> Developer Tools). Go to Network tab, and throttle to Slow 4G

  1. Sign in with an existing account
  2. Send some messages (just to add items into the queue)
  3. Sign out
  4. Do steps 3 and 4 a couple of times

Expected Result:

Observe that OpenApp request was fired only once in the Network tab

Actual Result:

OpenApp request is sent each time user signs in

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/7d706641-675a-4c2b-aaef-7e62b400c0ea

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863414839450757624
  • Upwork Job ID: 1863414839450757624
  • Last Price Increase: 2024-12-02
Issue OwnerCurrent Issue Owner: @suneox

lanitochka17 avatar Nov 29 '24 18:11 lanitochka17

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 29 '24 18:11 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863414839450757624

melvin-bot[bot] avatar Dec 02 '24 02:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

melvin-bot[bot] avatar Dec 02 '24 02:12 melvin-bot[bot]

Hi! I'm Bartek from Callstack - expert contributor group. I’d like to take a look at this task.

burczu avatar Dec 05 '24 07:12 burczu

@suneox, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 05 '24 09:12 melvin-bot[bot]

This issue cannot be reproduced on the latest staging version v9.0.72-0. The current network filter in video has Preserve log enabled, ensuring that previous requests are retained. So I think we can retest without Preserve log enabled

Screenshot 2024-12-05 at 22 28 24

suneox avatar Dec 05 '24 15:12 suneox

@suneox Just checked on dev with Preserve log disabled and the issue is still reproducible.

burczu avatar Dec 06 '24 10:12 burczu

@suneox Just checked on dev with Preserve log disabled and the issue is still reproducible.

@burczu I’ve just verified on the latest main v9.0.72-1, and this issue cannot be reproduced. Could you please share a recording of the issue?

https://github.com/user-attachments/assets/8bc9a3c2-a396-4528-95a4-d2e961862c5d

suneox avatar Dec 07 '24 10:12 suneox

Hey @suneox! I'm not sure if understand the issue correctly, but in your video the OpenApp request is called every login, which should not happen, based on the description of the issue. Am I confusing something?

burczu avatar Dec 09 '24 08:12 burczu

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 09 '24 16:12 melvin-bot[bot]

Hey @suneox! I'm not sure if understand the issue correctly, but in your video the OpenApp request is called every login, which should not happen, based on the description of the issue. Am I confusing something?

API OpenApp is included personal data so i think it makes sense to called after sign in. Based on issue #50076 is prevented duplicate request OpenAppbut the test step doesn't match with checklist. And the QC team has enabled the Preserve Log option during testing, which I believe is the reason behind this issue.

cc: @lanitochka17

suneox avatar Dec 09 '24 16:12 suneox

This is not a bug.

muttmuure avatar Dec 09 '24 18:12 muttmuure