[$250] [HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Search - Pay button from the dropdown does nothing when trying to pay without bank account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.68-2 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace (do not set up bank account).
3. Go to workspace chat.
4. Submit an expense.
5. Click on the down caret button on the expense preview in the workspace chat.
6. Select Pay with Expensify.
7. Go to Search.
8. Click Pay on the expense item.
9. Note that it opens expense details RHP.
10. Close the RHP.
11. Select the same expense via checkbox.
12. Click on the dropdown.
13. Click Pay.

Expected Result:

Expense detalis RHP will open since the expense cannot be paid directly because bank account is not set up.

Actual Result:

Clicking Pay from the dropdown list does not do anything except that the Pay button loads and reverts to the initial state.

Workaround:

Unknown

Platforms:

• [x] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/2c3067ae-1389-46ca-921c-4a44ec18a44b

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866077420608244096
• Upwork Job ID: 1866077420608244096
• Last Price Increase: 2024-12-09

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[neonbhai]

Not reproducible for me on main:

https://github.com/user-attachments/assets/989b73d6-c1cf-425d-a616-6af778404a02

[aldo-expensify]

Seems like the backend is returning an error:

{
    "onyxData": [
        {
            "key": "snapshot_243428839",
            "onyxMethod": "merge",
            "value": {
                "data": {
                    "report_8794135360699161": {
                        "hasError": true
                    }
                }
            }
        }
    ],
    "httpCode": 200,
    "jsonCode": 200,
    "authResponseMessage": "200 OK",
    "requestID": "8e9e95da7b892d84-YVR"
}

paymentData's amount looks wrong:

paymentData: [{"reportID":"8794135360699161","amount":0,"paymentType":"ACH"}]

The logs don't appear to show any error:

https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%228e9e95da7b892d84-YVR%22)+AND+timestamp:[2024-11-28T23:47:15.649Z+TO+2024-11-29T01:47:15.649Z]&index=logs_expensify-031418

In production the Pay button simply doesn't appear:

Maybe the bug is that the button appears in staging when it shouldn't?

[aldo-expensify]

This can be time consuming to test because the Search view keeps getting stuck "loading" even if the Search request already returned 200:

(This is a new account, so there isn't much data on it)

[aldo-expensify]

@luacmartins @lakchote I think you may be more familiar with this feature, do you know if the Pay button should show in the dropdown when you select Pay in Expensify but you don't have a bank account?

[aldo-expensify]

This is a new feature introduced in this Pr: https://github.com/Expensify/App/pull/51913/files

[lakchote]

Taking the lead on this one to fix the blocker

[lakchote]

@luacmartins @lakchote I think you may be more familiar with this feature, do you know if the Pay button should show in the dropdown when you select Pay in Expensify but you don't have a bank account?

Answered in Slack here

[shubham1206agra]

@lakchote Please assign me the issue

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53304

If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:

[melvin-bot[bot]]

@lakchote @garrettmknight @lakchote The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.69-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53304

If no regressions arise, payment will be issued on 2024-12-09. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@shubham1206agra @garrettmknight @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@garrettmknight)

• [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [x] I have verified the payment summary above is correct

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021866077420608244096

[melvin-bot[bot]]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[garrettmknight]

@shubham1206agra offer is out to you.

[shubham1206agra]

@garrettmknight Offer accepted

[garrettmknight]

Cool, paid and closed.