App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-12-17] Web - Workspace - Workspace tooltip does not adjust immediately after updating workspace name

Open IuliiaHerets opened this issue 1 year ago β€’ 11 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace settings > Profile.
  4. Hover over workspace avatar under "Submit expenses using your workspace chat below:"
  5. Note that the tooltip does not cover the avatars and remember the width of workspace avatar tooltip.
  6. Change the workspace name to longer name (as long as possible).
  7. Hover over workspace avatar under "Submit expenses using your workspace chat below:"
  8. Note that the tooltip covers the avatars and the width of workspace avatar tooltip is the same as Step 5.
  9. Go back to workspace list, and return to the same workspace profile.
  10. Hover over workspace avatar under "Submit expenses using your workspace chat below:"
  11. Note that now the tooltip does not cover the avatars and the width of workspace avatar tooltip is adjusted.

Expected Result:

In Step 8, the workspace avatar tooltip should adjust accordingly after workspace name is updated.

Actual Result:

In Step 8, the workspace avatar tooltip does not adjust accordingly after workspace name is updated. It covers the avatars when the new name is very longer while maintaining the same tooltip width.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/e4a87110-e9eb-4c91-8173-df9fc60ccc9f

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MitchExpensify

IuliiaHerets avatar Nov 28 '24 20:11 IuliiaHerets

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Nov 28 '24 20:11 melvin-bot[bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 28 '24 20:11 melvin-bot[bot]

πŸ’¬ A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Nov 28 '24 20:11 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Nov 28 '24 20:11 github-actions[bot]

Demoting as its minor but asking the authors of the feature to follow up, thanks

mountiny avatar Nov 28 '24 22:11 mountiny

cc @nkdengineer

s77rt avatar Nov 28 '24 23:11 s77rt

I'm here

nkdengineer avatar Nov 29 '24 03:11 nkdengineer

@s77rt we have a follow up PR here

nkdengineer avatar Nov 29 '24 09:11 nkdengineer

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53300

If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment through NewDot Manual Requests
  • @nkdengineer requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

@s77rt @MitchExpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

BugZero Checklist:

  • [ ] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [ ] 1a. Result of the original design (eg. a case wasn't considered)
  • [ ] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • [ ] 2b. Reported on staging (eg. found during regression or PR testing)
  • [ ] 2d. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [ ] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [ ] 3d. QA
  • [ ] 3z. Other:
  • [ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment:

  • [ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template
  • [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree πŸ‘ or πŸ‘Ž

MitchExpensify avatar Dec 13 '24 01:12 MitchExpensify

Payment summary:

  • $250 @s77rt requires payment through NewDot Manual Requests
  • $250 @nkdengineer requires payment (Needs manual offer from BZ)

MitchExpensify avatar Dec 13 '24 01:12 MitchExpensify

Please complete the BZ steps here @s77rt, thanks

MitchExpensify avatar Dec 13 '24 01:12 MitchExpensify

BugZero Checklist:

  • [X] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [ ] 1a. Result of the original design (eg. a case wasn't considered)
  • [X] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • [X] 2b. Reported on staging (eg. found during regression or PR testing)
  • [ ] 2d. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [ ] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [X] 3d. QA
  • [ ] 3z. Other:
  • [X] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: Not needed. This issue is a regression and the author is aware of the cause

  • [X] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: n/a

  • [X] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Bug requires regression test: No

Regression Test Proposal Template
  • [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree πŸ‘ or πŸ‘Ž

s77rt avatar Dec 13 '24 13:12 s77rt

@MitchExpensify Please close this issue. No payment is due as it's a regression

s77rt avatar Dec 13 '24 13:12 s77rt