App icon indicating copy to clipboard operation
App copied to clipboard

Concierge chat shows only most recent message and all other turns into an infinite skeleton

Open m-natarajan opened this issue 1 year ago • 9 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Need reproduction Reproducible in production?: need reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation (hyperlinked to channel name): expensify-quality

Action Performed:

  1. Open ND
  2. Go to Concierge chat

Expected Result:

All chats should be loading

Actual Result:

Concierge chat initially loads, then all but the most recent message turns into an infinite skeleton

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Please check in the channel

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @janicduplessis

m-natarajan avatar Nov 28 '24 18:11 m-natarajan

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Nov 28 '24 18:11 MelvinBot

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 28 '24 18:11 melvin-bot[bot]

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

melvin-bot[bot] avatar Nov 28 '24 18:11 melvin-bot[bot]

I can't repro - Replied in thread.

RachCHopkins avatar Nov 28 '24 22:11 RachCHopkins

@RachCHopkins, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 02 '24 10:12 melvin-bot[bot]

Per the above thread @janicduplessis is going to take a look at this.

RachCHopkins avatar Dec 02 '24 23:12 RachCHopkins

@janicduplessis Can you please comment on the GH so I can assign it to you, thanks.

techievivek avatar Dec 03 '24 05:12 techievivek

I will have a look at this today

janicduplessis avatar Dec 03 '24 15:12 janicduplessis

I'm having trouble reproducing this one.

Posted in slack:

Is anyone able to reproduce this on a new account? I've had no luck there. From looking at the code the only way this kind of skeleton can show is when the state isLoadingInitialReportActions or isLoadingOlderReportActions is true, but I don't see any calls to GetOlderReportActions in the logs so it must be the first case. This is set to true when calling OpenReport I've looked at the OpenReport calls from the logs for report id 4084426685399241 which is one of the problematic ones in the posted screenshots, it is hard to see exactly what is going on, I wonder if some race condition in SequentialQueue could cause the OpenReport response to never be processed.

janicduplessis avatar Dec 06 '24 20:12 janicduplessis

I wasn't able to repro it, but I've seen it multiple time in FS reviews.

trjExpensify avatar Dec 09 '24 11:12 trjExpensify

@janicduplessis, @RachCHopkins, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

@janicduplessis @RachCHopkins @techievivek this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 12 '24 09:12 melvin-bot[bot]

@janicduplessis, @RachCHopkins, @techievivek Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 12 '24 09:12 melvin-bot[bot]

@janicduplessis I know you said in Slack that you were going to get into this again, how are you getting on?

RachCHopkins avatar Dec 13 '24 04:12 RachCHopkins

Investigating this, @muttmuure said he has more cases to show me. Currently we think it might be related to OpenReport call never resolving.

janicduplessis avatar Dec 13 '24 17:12 janicduplessis

@janicduplessis, @RachCHopkins, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 17 '24 09:12 melvin-bot[bot]

Not overdue. @janicduplessis, are you looking into this? Any help you need from the backend for this?

techievivek avatar Dec 18 '24 09:12 techievivek

@janicduplessis, @RachCHopkins, @techievivek Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 23 '24 09:12 melvin-bot[bot]

Calm down Melvin, it's the holidays... 🎄

RachCHopkins avatar Dec 23 '24 22:12 RachCHopkins

@janicduplessis, @RachCHopkins, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 27 '24 09:12 melvin-bot[bot]

Fix linked in thread, going to close!

muttmuure avatar Dec 29 '24 23:12 muttmuure

@janicduplessis, @RachCHopkins, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 14 '25 09:02 melvin-bot[bot]

@muttmuure why was this reopened ?

hannojg avatar Feb 17 '25 14:02 hannojg

@janicduplessis, @RachCHopkins, @techievivek Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Feb 18 '25 09:02 melvin-bot[bot]

@janicduplessis, @RachCHopkins, @techievivek 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Feb 20 '25 09:02 melvin-bot[bot]

@janicduplessis, @RachCHopkins, @techievivek 12 days overdue now... This issue's end is nigh!

melvin-bot[bot] avatar Feb 24 '25 09:02 melvin-bot[bot]

This issue has not been updated in over 14 days. @janicduplessis, @RachCHopkins, @techievivek eroding to Weekly issue.

melvin-bot[bot] avatar Feb 27 '25 09:02 melvin-bot[bot]

This issue has not been updated in over 15 days. @janicduplessis, @RachCHopkins, @techievivek eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Mar 24 '25 09:03 melvin-bot[bot]