App icon indicating copy to clipboard operation
App copied to clipboard

IOS - Lag when swiping on distance rate settings page

Open IuliiaHerets opened this issue 1 year ago • 4 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5266802 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Create a workspace
  2. Enable distance rates
  3. Go to distance rate editor
  4. Go to Add a rate or edit a rate page
  5. Swipe from left to right to go back
  6. Swipe again and again to compare the swipe behavior (While swiping release your finger from the screen after the first swipe, don't go from edge to edge while holding your finger on the screen)

Expected Result:

Swipe behavior stays the same throughout the app

Actual Result:

Swipe behavior on distance rate page has a lag

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [x] iOS: Standalone
  • [x] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/c517bf19-fd75-4bda-964e-06ba3f61b68b

View all open jobs on GitHub

IuliiaHerets avatar Nov 27 '24 13:11 IuliiaHerets

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 27 '24 13:11 melvin-bot[bot]

I'm catching up from being OOO for the holiday last week. Will get this slotted in tomorrow.

johncschuster avatar Dec 02 '24 22:12 johncschuster

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 06 '24 09:12 melvin-bot[bot]

I couldn't action this today. I will check it out this weekend.

johncschuster avatar Dec 06 '24 23:12 johncschuster

Job added to Upwork: https://www.upwork.com/jobs/~021866174807187903196

melvin-bot[bot] avatar Dec 09 '24 17:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

melvin-bot[bot] avatar Dec 09 '24 17:12 melvin-bot[bot]

@johncschuster @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 11 '24 09:12 melvin-bot[bot]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash avatar Dec 12 '24 12:12 VickyStash

Updates:

  • I was able to reproduce the issue, but in the production build only. It's not reproduced on the simulator and I have some issues with running dev build on the device, which I'm trying to resolve.
  • The issue is reproduced on similar screens as well (ex: Workspace Categories, Tags, Taxes). My main guess is that it's all related to useFocusEffect hook usage. But I need to be able to test in the dev mode to be sure and find the fix. I'll keep you updated.

VickyStash avatar Dec 12 '24 22:12 VickyStash

@johncschuster, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 13 '24 09:12 melvin-bot[bot]

Not overdue, WIP on it!

VickyStash avatar Dec 13 '24 09:12 VickyStash

There is no proposal to review yet. Not overdue.

abdulrahuman5196 avatar Dec 13 '24 11:12 abdulrahuman5196

I've updated the prod app version to the latest, and I'm not able to reproduce it anymore!

https://github.com/user-attachments/assets/ada3d51c-1c21-4c64-8ce7-28f36e7050b5

@IuliiaHerets @abdulrahuman5196 Could you confirm if the issue is still reproducible for you?

VickyStash avatar Dec 13 '24 11:12 VickyStash

Asking for a retest

johncschuster avatar Dec 13 '24 15:12 johncschuster

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 16 '24 16:12 melvin-bot[bot]

Not overdue, waiting for the issue to be re-tested!

VickyStash avatar Dec 16 '24 16:12 VickyStash

Asking for a retest

Waiting on this

abdulrahuman5196 avatar Dec 16 '24 17:12 abdulrahuman5196

@abdulrahuman5196 @johncschuster Issue is not reproducible anymore

https://github.com/user-attachments/assets/52bbb047-68c2-4915-9ecf-04987a474aa0

IuliiaHerets avatar Dec 16 '24 20:12 IuliiaHerets

@johncschuster I think we can close this issue then.

abdulrahuman5196 avatar Dec 17 '24 08:12 abdulrahuman5196

@johncschuster, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 20 '24 09:12 melvin-bot[bot]

kind bump @johncschuster 🙂

VickyStash avatar Dec 20 '24 16:12 VickyStash