Update SearchPageHeaderInput to display recent search and chats

[Kicu]

Explanation of Change

This PR refactors SearchPageHeaderInput and SearchRouter, to put all (expect contextual search) Router features into the Input on Search results. Also when cmd+k shortcut is used while on Search Results Page, then we will focus on the Input and not show the Router.

Fixed bugs

• if the query is empty, the first item on the list will also be empty, and will navigate to default search
• focus on android mobile: https://github.com/Expensify/App/pull/52568#issuecomment-2501822936
• [VERIFY] check performance regression - https://github.com/Expensify/App/pull/52568#issuecomment-2502041114

Other things

1. I was unable to properly fix box height: https://github.com/Expensify/App/pull/52568#issuecomment-2501822697 The reason is that I believe this is a problem deeper in the SelectionList. I played with different styles, max-heights etc and none of this changed the behavior. I'm providing a video which shows that from the perspective of Search list components there is exactly 1 render, which introduces all the items, and there is nothing weird happening with data lengths. Thus the source of the flicker is most likely inside SelectionList, and I'd prefer to not change this list in this PR

flicker with console logs of renders

https://github.com/user-attachments/assets/ee474c6c-08cc-464d-bd7e-34706ca1455c

2. Keyboard navigation will sometimes jump out from suggestions the Search results below. This happens only when we have 1 item in the list, and so I think it should not be a big problem. The source lies much deeper in the code, because `SelectionList` simply always attaches a global keyboard handler for arrows UP/DOWN, and is not ready to work in cases where there are 2 lists. Source: https://github.com/Expensify/App/blob/main/src/components/SelectionList/BaseSelectionList.tsx#L317 This is a bigger problem that should be solved in a separate issue IMO.

Fixed Issues

$ https://github.com/Expensify/App/issues/53126 PROPOSAL:

Tests

• verify that cmd+k will focus Input when on Search results page
• verify that the Input on Search results page has the same items as Router
• verify you can navigate from Search results page to a chat via list items

Offline tests

QA Steps

Same as Tests

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Android focus bug fix

https://github.com/user-attachments/assets/a9356624-5f19-4ad5-8bfc-84cb28639692

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/3d99aeb8-b75e-4869-bc5d-8f3848294dca

MacOS: Desktop

[relrod]

Can you add a test to show what this is solving, and a changelog fragment?

[Akasurde]

@elmeriniemela Are you still working on this? Thanks.

needs_info

[elmeriniemela]

@Akasurde Not really, unfortunately I don't have the resources to develop the tests related to this. Feel free to take this issue further.

[mattclay]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[webknjaz]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[webknjaz]

This needs a rebase for the CI to pick up the branch.

[ansibot]

@elmeriniemela This PR is waiting for your response. Please respond or the PR will be closed.

click here for bot help

[elmeriniemela]

Hi, the comment in the code explains why depth argument is needed when 'refspecs' variable is empty. However the condition adds it only when "if refspecs" when it should be "if not refspecs". So there is clearly a contradiction with the intention of the developer (expressed in comment) and the actual code.

And this causes an error as explained in the PR description.