Expensify
[HOLD for payment 2024-12-11] Android - Start chat - Huge spacing between bottom button and offline indicator
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- Device navigation is buttons instead of swipe gestures.
- Launch ND or hybrid.
- Go offline.
- Open FAB > Start chat.
- Tap Add to group next to any user.
- Note that there is huge spacing between Next button and offline indicator.
- Go to #room.
- Note that there is huge spacing between Create room button and offline indicator.
Expected Result:
There should not be huge spacing between bottom button and offline indicator.
Actual Result:
There is huge spacing between bottom button and offline indicator.
This issue is not reproducible if device navigation uses swipe gestures.
Workaround:
Unknown
Platforms:
- [x] Android: Standalone
- [x] Android: HybridApp
- [ ] Android: mWeb Chrome
- [ ] iOS: Standalone
- [ ] iOS: HybridApp
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/f1d76c8a-a479-4c67-a6b6-875caf87a5eb
Issue Owner
Current Issue Owner: @sakluger
Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chrispader is going to take this over (according to Slack conversation)
This is purely a UI issue on Android native, not blocking the user from using the App. We are working on more holistic changes for the safe area and padding in android native
@mountiny do you mind linking the PR?
Also, @chrispader, if you would like me to assign you on this GH issue, you'll need to leave a comment. If you don't need to be assigned, then no worries.
ah it was not linked correctly in the PR, here it is https://github.com/Expensify/App/pull/53250
The space between offline indicator and the button is still visible. Also, the offline indicator overlaps the navigation tab of the device. Build 9.0.70-1
https://github.com/user-attachments/assets/b9b1a028-596b-41ae-b0b5-3b0847ed3941
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.70-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53250
If no regressions arise, payment will be issued on 2024-12-11. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @kirillzyusko does not require payment (Contractor)
@mountiny @sakluger @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
No payment required, but @kirillzyusko could you please complete the BZ checklist before we close the issue? Thanks!
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
We can close this issue as soon as @kirillzyusko completes the BZ checklist.
BugZero Checklist:
- [x] [Contributor] Classify the bug:
Source of bug:
- [ ] 1a. Result of the original design (eg. a case wasn't considered)
- [x] 1b. Mistake during implementation
- [ ] 1c. Backend bug
- [ ] 1z. Other:
Where bug was reported:
- [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
- [x] 2b. Reported on staging (eg. found during regression or PR testing)
- [x] 2d. Reported on a PR
- [ ] 2z. Other:
Who reported the bug:
-
[ ] 3a. Expensify user
-
[ ] 3b. Expensify employee
-
[ ] 3c. Contributor
-
[ ] 3d. QA
-
[x] 3z. Other: Agency member
-
[x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The author fixed it
-
[x] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
-
[x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
-
[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
- Login to the App using an account that has a workspace chat.
Test:
No need for this specific test, its a generic testing