App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat

Open IuliiaHerets opened this issue 1 year ago • 15 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5267318&group_by=cases:section_id&group_order=asc&group_id=229067 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Tap on the FAB and select "Start Chat"
  3. Add some users to a group.
  4. Tap on "Next"
  5. Tap on "Start Group"
  6. Verify the group is created and that compose box and information message are correctly displayed.

Expected Result:

When a group chat is created, compose box and information message should be displayed in a correct position.

Actual Result:

Compose box and group information message are displayed floating on top of the screen when a new group chat is created. Issue reproducible on hybrid app only.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/29c47243-834d-4f80-bd86-490d5e3330cc

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @DylanDylann

IuliiaHerets avatar Nov 27 '24 07:11 IuliiaHerets

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 27 '24 07:11 melvin-bot[bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Nov 27 '24 07:11 melvin-bot[bot]

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Nov 27 '24 07:11 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Nov 27 '24 07:11 github-actions[bot]

@chrispader @kirillzyusko for 👀 I think we can demote if we are soon to deploy, as this is minor issue that does not block the user completely but it definitely not looking good.

Lets discuss in the slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1732692440640569

mountiny avatar Nov 27 '24 11:11 mountiny

@staszekscp @mateuuszzzzz could you look into this one please? its not repro in standalone android app.

Demoting as its minor ui issue on one platform not blocking the user

mountiny avatar Nov 27 '24 22:11 mountiny

@mountiny I'll grab this one

jnowakow avatar Nov 28 '24 10:11 jnowakow

Thanks, lets go!

mountiny avatar Nov 28 '24 11:11 mountiny

Not sure if it's the same bug but there is also version when instead of creating group chat opening 1:1 chat breaks display (it can be reproduced in standalone ND)

https://github.com/user-attachments/assets/42f5868d-5ea5-41b0-89a2-03e4e6fbfc68

jnowakow avatar Nov 28 '24 13:11 jnowakow

I'm not able to reproduce bug from this issue anymore. I think I saw it at the beginning but now I'm not able to reproduce it anymore. The animation is not very smooth but in the end composer is on its place. I tried release build as well

https://github.com/user-attachments/assets/739e5a70-1173-4304-99bd-f4f74baed2f6

jnowakow avatar Nov 29 '24 08:11 jnowakow

@jnowakow Thank you!

Lets keep an eye out for it then

mountiny avatar Nov 29 '24 09:11 mountiny

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Nov 29 '24 09:11 MelvinBot

@strepanier03, @mountiny, @jnowakow Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 02 '24 09:12 melvin-bot[bot]

Waiting for reproduction steps

mountiny avatar Dec 02 '24 10:12 mountiny

@mountiny I think I found the reproduction steps and solution for this one while looking at other issue It's here https://github.com/Expensify/App/pull/53699

jnowakow avatar Dec 06 '24 12:12 jnowakow

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 26 '24 20:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.78-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53699

If no regressions arise, payment will be issued on 2025-01-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @jnowakow does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Dec 26 '24 20:12 melvin-bot[bot]

@DylanDylann @strepanier03 @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 26 '24 20:12 melvin-bot[bot]

Payment Summary

Upwork Job

  • Contributor: @jnowakow is from an agency-contributor and not due payment
  • ROLE: @DylanDylann paid $250 via Upwork (offer)

BugZero Checklist (@strepanier03)

  • [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [x] I have verified the payment summary above is correct

melvin-bot[bot] avatar Jan 02 '25 09:01 melvin-bot[bot]

@DylanDylann - I hired you in Upwork, I'll keep an eye out and pay when I see it accepted.

strepanier03 avatar Jan 03 '25 22:01 strepanier03

@strepanier03, @mountiny, @jnowakow, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jan 07 '25 09:01 melvin-bot[bot]

I paid the job and closed the contract, thanks @DylanDylann. Closing this out now.

strepanier03 avatar Jan 08 '25 21:01 strepanier03