[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Taxes - Save button appears above the keyboard with huge spacing in Name page
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team
Action Performed:
- Launch the app.
- Go to workspace settings > Taxes.
- Tap Add rate.
- Tap Name.
Expected Result:
Save button will not appear above the keyboard with huge spacing.
Actual Result:
Save button appears above the keyboard with huge spacing or overlap with keyboard. Same happens in Report fields. Seems issue is repro only with Samsung devices. Tester used Samsung Galaxy Z Fold4 device
Workaround:
Unknown
Platforms:
- [x] Android: Standalone
- [x] Android: HybridApp
- [ ] Android: mWeb Chrome
- [ ] iOS: Standalone
- [ ] iOS: HybridApp
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/294e3fef-9f3e-47ca-acb3-c16600dab3ad
https://github.com/user-attachments/assets/9fc9abc6-91e2-461a-a692-53f51de93bdb
Issue Owner
Current Issue Owner: @isabelastisser
Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
💬 A slack conversation has been started in #expensify-open-source
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Seems like there are a few deploy blockers related to the way buttons appear in Android. Clarifying in the issue linked above ^
Hello, I'm Kiryl from Margelo expert agency and I'd like to work on that problem (most likely this regression was introduced by my changes in edge-to-edge PR).
Fix CPed
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.67-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53209
If no regressions arise, payment will be issued on 2024-12-05. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @kirillzyusko does not require payment (Contractor)
- @c3024 requires payment (Needs manual offer from BZ)
@c3024 @isabelastisser @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53209
If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @kirillzyusko does not require payment (Contractor)
- @c3024 requires payment (Needs manual offer from BZ)
@c3024 @isabelastisser @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Not overdue, payment on Dec 7.
Payment Summary
Upwork Job
- Contributor: @kirillzyusko is from an agency-contributor and not due payment
- Reviewer: @c3024 owed $250 via NewDot
BugZero Checklist (@isabelastisser)
- [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
Payment for this issue was handled here for all edge-to-edge mode PRs. No payment is due here.