App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Chat - Hidden appears when mentioning a non existent user from another device

Open lanitochka17 opened this issue 1 year ago • 10 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.67-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

  1. [User A] Sign in as a new Gmail account
  2. [User A] Create a workspace and invite a member
  3. [User A] Enable workflows for the workspace and make the invited user become the first approver
  4. [User B] Sign in and mention a non existent user in the workspace chat

Expected Result:

Hidden doesn't appear for both devices

Actual Result:

The mention appears as hidden for the other device

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/1475069e-85fa-4531-b97c-eb830cba1f0b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864379866425027064
  • Upwork Job ID: 1864379866425027064
  • Last Price Increase: 2024-12-04
Issue OwnerCurrent Issue Owner: @rayane-djouah

lanitochka17 avatar Nov 26 '24 21:11 lanitochka17

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 26 '24 21:11 melvin-bot[bot]

@abekkala Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 02 '24 09:12 melvin-bot[bot]

@abekkala 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Dec 04 '24 09:12 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864379866425027064

melvin-bot[bot] avatar Dec 04 '24 18:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

melvin-bot[bot] avatar Dec 04 '24 18:12 melvin-bot[bot]

~~@abekkala I think that this is a backend bug issue and needs to be internal~~

rayane-d avatar Dec 06 '24 17:12 rayane-d

Hmm, the backend is returning the correct data:

Screenshot 2024-12-06 at 6 31 17 PM

It might be a frontend bug.

rayane-d avatar Dec 06 '24 17:12 rayane-d

Screenshot 2024-12-06 at 6 35 06 PM

rayane-d avatar Dec 06 '24 17:12 rayane-d

Looking for proposals!

rayane-d avatar Dec 06 '24 17:12 rayane-d

Some data to show on FE is short of while updating:

[info] [Report] Handled multipleEvents event sent by Pusher -
...
{"key":"personalDetailsList","onyxMethod":"merge","value":{"18802639":{"accountID":18802639,"avatar":"https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_8.png",
///////// no displayName /////////
"firstName":"","lastName":"","status":null}}}],
"eventType":"onyxApiUpdate"}],"lastUpdateID":3287938603,"previousUpdateID":3287133456}

Here above should be displayName like this: displayName: "[email protected]"

jacobkim9881 avatar Dec 07 '24 15:12 jacobkim9881

@abekkala @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

@abekkala, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 11 '24 16:12 melvin-bot[bot]

@jacobkim9881 Do you think that this is a backend bug?

rayane-d avatar Dec 11 '24 22:12 rayane-d

@rayane-djouah As a workaround w/o displayName, this code returns hidden name: https://github.com/Expensify/App/blob/082e14b9bc1259c329c7cd186ee8f21c0397f6fb/src/libs/ReportActionsUtils.ts#L1171-L1176 As I know we can get displayName on FE. However it seems the issue is not reproducible.

jacobkim9881 avatar Dec 12 '24 05:12 jacobkim9881

@abekkala, @rayane-djouah Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 17 '24 09:12 melvin-bot[bot]

@abekkala - Could you please ask QA to retest? Thanks!

rayane-d avatar Dec 17 '24 10:12 rayane-d

https://expensify.slack.com/archives/C9YU7BX5M/p1734534892566609

abekkala avatar Dec 18 '24 15:12 abekkala

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 18 '24 16:12 melvin-bot[bot]

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 21 '24 02:12 mvtglobally

https://github.com/Expensify/App/issues/53172#issuecomment-2557961547

rayane-d avatar Dec 21 '24 21:12 rayane-d

@abekkala @rayane-djouah this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

@abekkala, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 25 '24 09:12 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 25 '24 16:12 melvin-bot[bot]

https://github.com/Expensify/App/issues/53172#issuecomment-2557961547

rayane-d avatar Dec 26 '24 23:12 rayane-d

Issue not reproducible during KI retests. (Second week)

mvtglobally avatar Dec 30 '24 04:12 mvtglobally

https://github.com/Expensify/App/issues/53172#issuecomment-2565023385

rayane-d avatar Dec 30 '24 08:12 rayane-d

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Jan 01 '25 16:01 melvin-bot[bot]

https://github.com/Expensify/App/issues/53172#issuecomment-2565023385

rayane-d avatar Jan 01 '25 17:01 rayane-d

@abekkala, @rayane-djouah Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Jan 07 '25 09:01 melvin-bot[bot]