Expensify
LHN - There is no "Your space" chat when login after being added to WS
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.67-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
- Navigate to http://www.staging.new.expensify.com/
- Admin - Create workspace and add a member of non existing user(user A)
- User A - Log in with other tab using the account used in step 2
Expected Result:
After the user log in there is "Your space" chat
Actual Result:
There is no "your space" in LHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Standalone
- [ ] Android: HybridApp
- [x] Android: mWeb Chrome
- [ ] iOS: Standalone
- [ ] iOS: HybridApp
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/5b915807-e052-4c29-afc3-a3b494381cd4
Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is a BE issue. If we sign in with a new account without being added to a WS, the self DM is pinned, so it's shown on the LHN. But if we sign in with a new account with being added to a WS, the self DM isn't pinned and because it's empty, it's hidden from the LHN.
It's `"isPinned": false,` report from `OpenApp` API:
[info] [Network] Finished API request in 670ms - {"command":"OpenApp","jsonCode":200,"requestID":"8e91db1e28fbea15-ICN"}
{
"onyxMethod": "mergecollection",
"key": "report_",
"value": {
"report_1571593283644459": {
"avatarUrl": null,
"chatReportID": null,
"chatType": "selfDM",
"currency": "USD",
"description": "",
"errorFields": {
"export": null,
"notFound": null
},
"fieldList": null,
"hasOutstandingChildRequest": false,
"hasOutstandingChildTask": false,
"hasParentAccess": null,
"invoiceReceiver": null,
"iouReportID": null,
"isCancelledIOU": false,
"isDeletedParentAction": null,
"isOwnPolicyExpenseChat": false,
///////////////////////It makes Your space hidden//////////////////////
"isPinned": false,
/////////////////////////////////////////////
"isWaitingOnBankAccount": false,
"lastActionType": "CREATED",
"lastActorAccountID": "18749792",
"lastMentionedTime": null,
"lastMessageHtml": "",
"lastMessageText": "",
"lastReadSequenceNumber": 0,
"lastReadTime": null,
"lastVisibleActionCreated": "2024-11-27 11:42:09.642",
"lastVisibleActionLastModified": "2024-11-27 11:42:09.642",
"managerID": 0,
"nonReimbursableTotal": 0,
"oldPolicyName": "",
"ownerAccountID": 18749792,
"parentReportActionID": null,
"parentReportID": null,
"participants": {
"18749792": {
"notificationPreference": "mute"
}
},
"permissions": [],
"policyAvatar": null,
"policyID": "_FAKE_",
"policyName": null,
"private_isArchived": "",
"reportID": "1571593283644459",
"reportName": "",
"stateNum": 0,
"statusNum": 0,
"total": 0,
"tripData": null,
"type": "chat",
"unheldNonReimbursableTotal": 0,
"unheldTotal": 0,
"visibility": null,
"welcomeMessage": "",
"writeCapability": "all"
},
"report_4695822381380308": {
"avatarUrl": null,
"chatReportID": null,
"chatType": "policyExpenseChat",
"currency": "USD",
"description": "",
"errorFields": {
"export": null,
"notFound": null
},
"fieldList": null,
"hasOutstandingChildRequest": false,
"hasOutstandingChildTask": false,
"hasParentAccess": null,
"invoiceReceiver": null,
"iouReportID": null,
"isCancelledIOU": false,
"isDeletedParentAction": null,
"isOwnPolicyExpenseChat": true,
"isPinned": true,
"isWaitingOnBankAccount": false,
"lastActionType": "CREATED",
"lastActorAccountID": "18749792",
"lastMentionedTime": null,
"lastMessageHtml": "",
"lastMessageText": "",
"lastReadSequenceNumber": 0,
"lastReadTime": "2024-11-27 11:42:09.703",
"lastVisibleActionCreated": "2024-11-27 11:42:09.703",
"lastVisibleActionLastModified": "2024-11-27 11:42:09.703",
"managerID": 0,
"nonReimbursableTotal": 0,
"oldPolicyName": "",
"ownerAccountID": 18749792,
"parentReportActionID": null,
"parentReportID": null,
"participants": {
"18747347": {
"notificationPreference": "always"
},
"18749792": {
"notificationPreference": "always"
}
},
"permissions": [],
"policyAvatar": "",
"policyID": "E0E7988685131342",
"policyName": "Jacobkim's Workspace 1",
"private_isArchived": "",
"reportID": "4695822381380308",
"reportName": "Chat Report",
"stateNum": 0,
"statusNum": 0,
"total": 0,
"tripData": null,
"type": "chat",
"unheldNonReimbursableTotal": 0,
"unheldTotal": 0,
"visibility": null,
"welcomeMessage": "",
"writeCapability": "all"
},
"report_5303854524092736": {
"avatarUrl": null,
"chatReportID": null,
"chatType": "system",
"currency": "USD",
"description": "",
"errorFields": {
"export": null,
"notFound": null
},
"fieldList": null,
"hasOutstandingChildRequest": false,
"hasOutstandingChildTask": false,
"hasParentAccess": null,
"invoiceReceiver": null,
"iouReportID": null,
"isCancelledIOU": false,
"isDeletedParentAction": null,
"isOwnPolicyExpenseChat": false,
"isPinned": false,
"isWaitingOnBankAccount": false,
"lastActionType": "CREATED",
"lastActorAccountID": "",
"lastMentionedTime": null,
"lastMessageHtml": "",
"lastMessageText": "",
"lastReadSequenceNumber": 0,
"lastReadTime": null,
"lastVisibleActionCreated": "2024-11-27 11:42:09.640",
"lastVisibleActionLastModified": "2024-11-27 11:42:09.640",
"managerID": 0,
"nonReimbursableTotal": 0,
"oldPolicyName": "",
"ownerAccountID": 0,
"parentReportActionID": null,
"parentReportID": null,
"participants": {
"11665625": {
"notificationPreference": "hidden"
},
"18749792": {
"notificationPreference": "hidden"
}
},
"permissions": [
"read"
],
"policyAvatar": null,
"policyID": "_FAKE_",
"policyName": null,
"private_isArchived": "",
"reportID": "5303854524092736",
"reportName": "Chat Report",
"stateNum": 0,
"statusNum": 0,
"total": 0,
"tripData": null,
"type": "chat",
"unheldNonReimbursableTotal": 0,
"unheldTotal": 0,
"visibility": null,
"welcomeMessage": "",
"writeCapability": "all"
},
"report_7645576970172785": {
"avatarUrl": null,
"chatReportID": null,
"chatType": "",
"currency": "USD",
"description": "",
"errorFields": {
"export": null,
"notFound": null
},
"fieldList": null,
"hasOutstandingChildRequest": false,
"hasOutstandingChildTask": false,
"hasParentAccess": null,
"invoiceReceiver": null,
"iouReportID": null,
"isCancelledIOU": false,
"isDeletedParentAction": null,
"isOwnPolicyExpenseChat": false,
"isPinned": true,
"isWaitingOnBankAccount": false,
"lastActionType": "ADDCOMMENT",
"lastActorAccountID": "8392101",
"lastMentionedTime": null,
"lastMessageHtml": "",
"lastMessageText": "Welcome to Expensify 👋 Hey there, I'm Concierge! If you have any questions a…",
"lastReadSequenceNumber": 0,
"lastReadTime": "2024-11-27 11:42:09.638",
"lastVisibleActionCreated": "2024-11-27 11:42:09.639",
"lastVisibleActionLastModified": "2024-11-27 11:42:09.639",
"managerID": 0,
"nonReimbursableTotal": 0,
"oldPolicyName": "",
"ownerAccountID": 0,
"parentReportActionID": null,
"parentReportID": null,
"participants": {
"8392101": {
"notificationPreference": "always"
},
"18749792": {
"notificationPreference": "always"
}
},
"permissions": [
"read",
"write"
],
"policyAvatar": null,
"policyID": "_FAKE_",
"policyName": null,
"private_isArchived": "",
"reportID": "7645576970172785",
"reportName": "Chat Report",
"stateNum": 0,
"statusNum": 0,
"total": 0,
"tripData": null,
"type": "chat",
"unheldNonReimbursableTotal": 0,
"unheldTotal": 0,
"visibility": null,
"welcomeMessage": "",
"writeCapability": "all"
}
}
}
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
@maddylewis I added to #retain cuz the roadmap doc says "Deliver amazing support to NewDot-exclusive customers and address pain points in daily use" and this bug seems like it's specific to NewDot-only users.
I also feel like there might be a reason why we're handling "your space" differently but I couldn't find GHs or discussions about without going too far down the 🐰🕳.
got it! @mallenexpensify - will you add a screenshot of the expected view? im not 100% sure what "your space" is referring to.
The one below, which shows when you create a new account from scratch
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@mallenexpensify - when you have a sec, could you write the responses to these prompts? and then ill add this to the HOT PICKS section of the Retain update today 👍
https://stackoverflowteams.com/c/expensify/questions/20462
Addressed some of the questions from the What are the requirements for a GitHub issue to be added to Hot Pick? SO here in #bug-zero
Created a BZ TextExpander snippet too! ;;hotpick
- What is the expected outcome?
- See expected behaviour in OP
- Why are we doing this / what value do we get out of this proposed change?
- "Your Space" account is supposed to exist and be shown, we want parity for the feature, as people will use it for notes.
- What problem are we solving?
- Feature inconsistency
-
Priority and Impact Low, maybe medium, but we want to get it done.
-
Reproduction Steps See OP
-
Estimation of how long the ticket might take to complete If I had to guess, it should be pretty quick/easy
-
Who has experience or domain knowledge that might help us complete it? Unsure, @jacobkim9881 provided details above that might be helpful
-
Related Issues Can't think of any
-
Can it be worked on by contributors or not? No, looks like it's backend and needs to be external
-
Context for Any Existing Workarounds N/A
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!