Expensify
[$250] Report action says automatically approved $0.00 via
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Reproducible in staging?: need reproduction Reproducible in production?: need reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @flodnv Slack conversation (hyperlinked to channel name): expensify-migrate
Action Performed:
- Have a report submitted and approved on a OD
- Open the report in ND
Expected Result:
Should show correct amount of the approved expense
Actual Result:
Report action says automatically approved $0.00 via
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Standalone
- [ ] Android: HybridApp
- [ ] Android: mWeb Chrome
- [ ] iOS: Standalone
- [ ] iOS: HybridApp
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021861506983862256537
- Upwork Job ID: 1861506983862256537
- Last Price Increase: 2024-12-03
Issue Owner
Current Issue Owner: @c3024
Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@m-natarajan can you please be a bit more descriptive than OD and ND coz most of us new contributors don't know what that is?
https://github.com/Expensify/App/blob/f4f8da74c100f2c5ddb666ff4314038010104cbf/contributingGuides/CONTRIBUTING.md?plain=1#L210-L211
Yeah definitely something weird going on with reports from OD showing on New
Job added to Upwork: https://www.upwork.com/jobs/~021861506983862256537
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)
@OfstadC Is there any specific way to reproduce it? when I submit the report from ND it properly shows the amount
but when I try to submit from OD it never auto approves even if I create an expense with lesser amount than the
Approve manually above some amount setting of the workspace.
This part of the step is unclear
- Have a report submitted and approved on a OD
How do we submit in OD so that it will be auto approved?
@OfstadC, @c3024 Huh... This is 4 days overdue. Who can take care of this?
How do we submit in OD so that it will be auto approved?
The workspace will need to have this set in Classic - Settings > Workspace > Members
https://help.expensify.com/articles/expensify-classic/reports/Require-review-for-over-limit-expenses
@OfstadC This one ?
I did set but when I submit the expense below that amount from ND it auto approves and the report action shows the amount properly and whenever I submit from OD it never auto-approves it requires a manual approval from the admin. It would be helpful if someone who can reproduce it record screenshots :+1:
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
whenever I submit from OD it never auto-approves it requires a manual approval from the admin.
Is the report you are testing under $200? I would set the randomly route reports to 0% as well.
whenever I submit from OD it never auto-approves it requires a manual approval from the admin.
Is the report you are testing under $200? I would set the randomly route reports to 0% as well.
Yes it is under that value and also I have tried to set it to 0% @OfstadC I think it would be better to have snapshots if you can reproduce it. Thx
@OfstadC @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@OfstadC, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!
@OfstadC I think it would be better to have snapshots if you can reproduce it. Thx
I'll see what I can do today 😃
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@OfstadC, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Sorry @FitseTLT I haven't had a chance to get reproducible steps put together quite yet. I'll tackle this on Tuesday when i'm back in office. Hopefully sooner 🤞
@OfstadC, @c3024 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Hmmm... i'm not sure how to reproduce 🤔
All expenses/reports from Classic should still appear in NewDot, yeah?
I created an expense report in a test account and it was auto approved, but I don't see it in New Expensify 🤔
@OfstadC, @c3024 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
I still can't get new reports to reproduce. But all the already migrated reports are showing this 🤔