App icon indicating copy to clipboard operation
App copied to clipboard

Hybrid - Android - App crashes on tapping "Domains" in settings page

Open IuliiaHerets opened this issue 1 year ago β€’ 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9. 0.66-0 Reproducible in staging?: N Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. Tap settings
  3. Tap Domains

Expected Result:

App must not crash on tapping "Domains" in settings page.

Actual Result:

App crashes on tapping "Domains" in settings page.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [x] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

2311.txt

https://github.com/user-attachments/assets/4ab0aeed-f476-4e55-9c63-89e9a0255f1e

View all open jobs on GitHub

IuliiaHerets avatar Nov 23 '24 13:11 IuliiaHerets

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 23 '24 13:11 melvin-bot[bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Nov 23 '24 13:11 melvin-bot[bot]

πŸ’¬ A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Nov 23 '24 13:11 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Nov 23 '24 13:11 github-actions[bot]

I am not sure if this is hybrid app related, this button just opens the page in a browser

mountiny avatar Nov 25 '24 14:11 mountiny

I couldn't reproduce this one in Browserstack @mountiny

youssef-lr avatar Nov 25 '24 16:11 youssef-lr

Redmi note 10s Android 13 was the device used

mountiny avatar Nov 25 '24 16:11 mountiny

This is the exception for this case

Fatal Exception: com.facebook.react.common.JavascriptException: Error: TaskQueue: Error with task : [Pusher] instance not found. Pusher.subscribe()
            most likely has been called before Pusher.init(), js engine: hermes, stack:
anonymous@1:3789481
processNext@1:846927
_processUpdate@1:845633
anonymous@1:524029
_callTimer@1:522946
_callReactNativeMicrotasksPass@1:523147
callReactNativeMicrotasks@1:525099
__callReactNativeMicrotasks@1:217573
anonymous@1:215773
__guard@1:217447
flushedQueue@1:215684
callFunctionReturnFlushedQueue@1:215540

       at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
       at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
       at android.os.Looper.loopOnce(Looper.java:211)
       at android.os.Looper.loop(Looper.java:300)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
       at java.lang.Thread.run(Thread.java:1012)
        

mountiny avatar Nov 25 '24 16:11 mountiny

@war-in @youssef-lr were not able to reproduce, same as on ios where the link opens in safari.

Going to demote for now, but lets keep this open as we are discussing some changes in the deeplinks logic in hybrid app

mountiny avatar Nov 25 '24 17:11 mountiny

Sounds good β€” thanks @mountiny!

CortneyOfstad avatar Nov 26 '24 19:11 CortneyOfstad

I believe this might have been fixed now, feel free to ask for a retest and close

mountiny avatar Nov 26 '24 20:11 mountiny

@youssef-lr, @CortneyOfstad Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 02 '24 09:12 melvin-bot[bot]

Sounds good β€” thanks Vit!

CortneyOfstad avatar Dec 02 '24 16:12 CortneyOfstad

@youssef-lr, @CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 06 '24 09:12 melvin-bot[bot]

Still waiting for it to be retested, so not overdue!

CortneyOfstad avatar Dec 06 '24 17:12 CortneyOfstad

@youssef-lr @CortneyOfstad this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 07 '24 10:12 melvin-bot[bot]

Still waiting on testing!

CortneyOfstad avatar Dec 09 '24 18:12 CortneyOfstad

Before this goes overdue β€” still waiting for it to be tested πŸ˜‚

CortneyOfstad avatar Dec 11 '24 18:12 CortneyOfstad

Going to also post in the room to see if we can get this moving

CortneyOfstad avatar Dec 11 '24 18:12 CortneyOfstad

Posted in #qa here β€” https://expensify.enterprise.slack.com/archives/C9YU7BX5M/p1733941658006679

CortneyOfstad avatar Dec 11 '24 18:12 CortneyOfstad

not repro

https://github.com/user-attachments/assets/9b43ca75-fff5-4cd0-81ee-75f2b09e5d58

mvtglobally avatar Dec 12 '24 16:12 mvtglobally

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 14 '24 05:12 mvtglobally

@youssef-lr, @CortneyOfstad Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 17 '24 09:12 melvin-bot[bot]

If this is no longer happening, let's close

muttmuure avatar Dec 17 '24 12:12 muttmuure