App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

Stash session and credentials during copilot access

Open dangrous opened this issue 1 year ago • 11 comments

Explanation of Change

This will allow us to remove the code removed in https://github.com/Expensify/Web-Expensify/pull/44547, but should not yet require that change. However, please test with and without that backend change locally (I did too but just to be safe)

Fixed Issues

$ https://github.com/Expensify/App/issues/51042 PROPOSAL:

Tests

Internally - please do the following

  1. Update your authtokens to expire after a short period (e.g. 20 seconds) here - I don't remember which one of these is the one that matters so you can update both to be safe

  2. As noted above please double check this works with and without https://github.com/Expensify/Web-Expensify/pull/44547.

  3. This can also be tested on Hybrid App with https://github.com/Expensify/Mobile-Expensify/pull/13289 - you don't need to do that here I don't think, but calling out that I did do that :)

  4. Create an account, verify it (log out and back in again) and add a copilot

  5. Log in as that copilot

  6. Copilot into the original account

  7. Verify that everything seems to work fine (requests go through, etc.)

  8. Switch back to the copilot's original account

  9. Verify that everything seems to work fine (requests go through, etc.)

  10. Wait 20 seconds (or however long you set your authtokens to expire)

  11. Do some more actions, and check for the Authenticate call to go through successfully.

  12. Verify that everything seems to work fine

  13. Repeat steps 3-9 (just to make sure that nothing goes weird with the copilot tokens).

  • [X] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Create an account, verify it (log out and back in again) and add a copilot
  2. Log in as that copilot
  3. Copilot into the original account
  4. Verify that everything seems to work fine (requests go through, etc.)
  5. Switch back to the copilot's original account
  6. Verify that everything seems to work fine (requests go through, etc.)
  7. Repeat steps 3-6 once.
  • [ ] Verify that no errors appear in the JS console

PR Author Checklist

  • [X] I linked the correct issue in the ### Fixed Issues section above
  • [X] I wrote clear testing steps that cover the changes made in this PR
    • [X] I added steps for local testing in the Tests section
    • [X] I added steps for the expected offline behavior in the Offline steps section
    • [X] I added steps for Staging and/or Production testing in the QA steps section
    • [X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • [X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [X] I included screenshots or videos for tests on all platforms
  • [X] I ran the tests on all platforms & verified they passed on:
    • [X] Android: Native
    • [X] Android: mWeb Chrome
    • [X] iOS: Native
    • [X] iOS: mWeb Safari
    • [X] MacOS: Chrome / Safari
    • [X] MacOS: Desktop
  • [X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • [X] I followed proper code patterns (see Reviewing the code)
    • [X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • [X] I verified that comments were added to code that is not self explanatory
    • [X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • [X] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • [X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [X] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [X] I followed the guidelines as stated in the Review Guidelines
  • [X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • [X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [X] I verified that if a function's arguments changed that all usages have also been updated correctly
  • [X] If any new file was added I verified that:
    • [X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [X] If a new CSS style is added I verified that:
    • [X] A similar style doesn't already exist
    • [X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • [X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [X] I verified that all the inputs inside a form are aligned with each other.
    • [X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

https://github.com/user-attachments/assets/45874753-abd1-484f-95c5-be944a6b063f

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

dangrous avatar Nov 22 '24 20:11 dangrous

Okay, this looks like it works properly with https://github.com/Expensify/Mobile-Expensify/pull/13289 and the web-e / backend changes!

dangrous avatar Nov 25 '24 19:11 dangrous

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Nov 25 '24 19:11 melvin-bot[bot]

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Nov 26 '24 07:11 melvin-bot[bot]

thanks @mollfpr! Yes unfortunately not something external folks can help with yet. @blimpich - let me know if you have any questions!

dangrous avatar Nov 26 '24 14:11 dangrous

Hey @mollfpr so I talked with @blimpich - do you think you could actually test this against the existing backend, and then, to test against the new backend changes we can sync up and I can give you an ngrok URL to my backend? Let me know!

dangrous avatar Dec 02 '24 17:12 dangrous

@dangrous Sure! I'll let you know when I'm finish the test with current BE.

mollfpr avatar Dec 02 '24 17:12 mollfpr

How are we looking on this one @mollfpr ? Thanks!

dangrous avatar Dec 05 '24 15:12 dangrous

I'm going to test it now! Sorry for the delay 🙏

mollfpr avatar Dec 05 '24 16:12 mollfpr

@dangrous Looks good! Although, I got logout when switch back to copilot account but I only experience it once.

https://github.com/user-attachments/assets/64cf30cf-eb7b-41af-a549-a2d70ae63dd7

Do you want to proceed with test the BE changes?

mollfpr avatar Dec 05 '24 16:12 mollfpr

Hm, weird - I wonder if that's just something with the site issues we're having right now. I guess we can move forward, and if you notice that come up again let me know!

I'll get my backend prepped with the necessary changes and ping you in Slack with an .env file you can use to connect.

dangrous avatar Dec 05 '24 18:12 dangrous

@dangrous I got an Onyx error after signing in.

Screenshot 2024-12-06 at 20 34 28

The report_ data has onyxMethod setcollection which is not a valid onyx method in onyx. I try to verify with the response on staging, and it has onyxMethod and mergecollection instead.

Screenshot 2024-12-06 at 20 36 32

mollfpr avatar Dec 06 '24 13:12 mollfpr

I'm able to modify the onyx so the error won't be raised. Continue to testing!

mollfpr avatar Dec 06 '24 14:12 mollfpr

Reviewer Checklist

  • [x] I have verified the author checklist is complete (all boxes are checked off).
  • [x] I verified the correct issue is linked in the ### Fixed Issues section above
  • [x] I verified testing steps are clear and they cover the changes made in this PR
    • [x] I verified the steps for local testing are in the Tests section
    • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
    • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I checked that screenshots or videos are included for tests on all platforms
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I verified tests pass on all platforms & I tested again on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • [x] I verified proper code patterns were followed (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
  • [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • [x] If a new component is created I verified that:
    • [x] A similar component doesn't exist in the codebase
    • [x] All props are defined accurately and each prop has a /** comment above it */
    • [x] The file is named correctly
    • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • [x] The only data being stored in the state is data necessary for rendering and nothing else
    • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • [x] All JSX used for rendering exists in the render method
    • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/4c560b8c-0001-4fb7-961e-9a3b26db1589

Android: mWeb Chrome

https://github.com/user-attachments/assets/f821e4af-48a6-439c-a696-1acf87785375

iOS: Native

https://github.com/user-attachments/assets/df297895-d164-4d08-ae19-97a647fc5748

iOS: mWeb Safari

https://github.com/user-attachments/assets/1a3a7c15-e8c6-48c3-abf0-56219277efed

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/d7ad02cc-e567-47b8-ad16-ba1f1526c471

MacOS: Desktop

https://github.com/user-attachments/assets/5aad7365-770d-4cc1-87f7-e7a35934ac2e

mollfpr avatar Dec 06 '24 15:12 mollfpr

@beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 06 '24 15:12 melvin-bot[bot]

Thanks @mollfpr! To confirm about the set/merge thing - is that something I need to look into changing in my back end PR? Or is it resolved?

dangrous avatar Dec 06 '24 15:12 dangrous

is that something I need to look into changing in my back end PR?

@dangrous Probably yes.

Interestingly, we have setcollection method in react-native-onyx.

https://github.com/Expensify/react-native-onyx/blob/5f4bf772aadb581bbe87d983a56d933e4cd9b55d/lib/OnyxUtils.ts#L39-L46

We have bumped the package https://github.com/Expensify/App/pull/53148. I think we can resolve the issue with pulled the latest main.

mollfpr avatar Dec 06 '24 17:12 mollfpr

Cool, I've merged main in both front and back end. Do you think we need to retest, or are we good for final approval from @blimpich (or @Beamanator who seems to have been auto-added unnecessarily)?

I misread your initial message too, the error is on sign in not related code.

dangrous avatar Dec 09 '24 18:12 dangrous

@dangrous I think it's good for final approval since it's not related to the issue changes.

mollfpr avatar Dec 10 '24 15:12 mollfpr

ah okay perfect - @blimpich can you give it the final run down? Thanks!

dangrous avatar Dec 10 '24 17:12 dangrous

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify avatar Dec 10 '24 18:12 OSBotify

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.74-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

github-actions[bot] avatar Dec 10 '24 23:12 github-actions[bot]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.74-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

github-actions[bot] avatar Dec 12 '24 01:12 github-actions[bot]