App
App copied to clipboard
Expensify
[HOLD] Keep navigation within the RHP when navigating from a report to an expense on the Search page
Background: Users often utilize the Search page to find and access reports through the Right-Hand Pane (RHP). The RHP allows them to view reports without leaving the Search page, providing a seamless and efficient experience.
Problem: When users attempt to view an expense from a report opened in the RHP, they are redirected to the Inbox, disrupting their workflow and preventing them from maintaining their original context.
Solution: Adjust the RHP navigation stack in Search so that any content accessed from within the RHP remains within it. This change will enable users to navigate from a report to its associated expenses entirely within the RHP, allowing for smooth, uninterrupted exploration of report details without leaving the Search page.
https://github.com/user-attachments/assets/59dcdbb9-1835-47d4-aefd-82b2e43a6d43
@shawnborton, @luacmartins, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
They are the same. I'll close the other issue in favor of this one, since it has a more structured P/S
Coupla' things:
- We are going to keep this moving forward, yes?
- I'm moving this project into #migrate to track along with this next wave of changes.
@trjExpensify @shawnborton can you share what the new navigation flows should be in the Search page? That'd give us a better idea if this is still needed or not
Basically what navigating from an expense/report row to a report in the main pane to an expense in the RHP then clicking any link in the RHP, etc
Native stack PR merged and getting through the follow up bugs, this will unblock the bottom tab refactor and these changes too
Hey there - sorry for the delay!
The general idea that we're toying around with is that you could potentially open up a report directly from the Search page, which might give us something like this:
The if you click on an expense on the report, we would open it up in the RHP:
I don't know what we should do about navigating from a report in Search to the workspace chat... part of me thinks if you click on the small link in the header here:
...that we would take you to the actual workspace chat over in the Inbox page? I'm not too sure really.
That being said, I do think it makes sense to keep the user in the RHP if they are navigating into a thread inside of an expense or something like that. Curious what you think though and how those potential changes might impact this particular GH issue.
That being said, I do think it makes sense to keep the user in the RHP if they are navigating into a thread inside of an expense or something like that.
So we'd keep the user in the RHP if they clicked any link in the RHP chat?
I wouldn't say "any link" but we'd want to keep them in the RHP if they were drilling down into a thread or something.
It gets a bit tricky though because in theory, you could first open up an expense in the RHP from the Search > All page. But then from the expense, you could go up a level and view the report. Maybe it's okay to keep that report in the RHP, but then we have a consistency where sometimes the report can be opened in the main content pane and sometimes it can be opened up in the RHP.
I think the best path forward might just be to try to keep the user in the RHP if they are navigating around within the RHP in relation to workspace chat/report/expense views.
Going to throw a HOLD on this one while we sort out some of the high-level discussions around Search V3. Sorry for the change of plans, but let's make sure we attack this one with alignment.
I wonder if we should just close this out in favor of my expense previews project? Feels like there is a lot of overlap here at least.
Reopening as we will want to do this after the navigation changes are in place cc @WojtekBoman
We will need to check if there are any considerations that changes
This issue has not been updated in over 15 days. @shawnborton, @luacmartins, @mountiny eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
@shawnborton, @luacmartins, @mountiny, @WojtekBoman, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.