Expensify
[$250] iOS Invoices - App freezes after deleting bank account
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.65-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- User has added bank account in Invoices section.
- Launch ND or hybrid app.
- Go to workspace settings > Invoices.
- Tap on the bank account.
- Tap Delete.
- Delete the bank account.
- Tap anywhere else.
Expected Result:
App will not freeze after deleting bank account.
Actual Result:
App freezes after deleting bank account.
Workaround:
Unknown
Platforms:
- [ ] Android: Standalone
- [ ] Android: HybridApp
- [ ] Android: mWeb Chrome
- [x] iOS: Standalone
- [x] iOS: HybridApp
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/26cd56e5-5a3e-4118-9cef-daab03db81db
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021861553347426346949
- Upwork Job ID: 1861553347426346949
- Last Price Increase: 2024-12-03
Issue Owner
Current Issue Owner: @yuwenmemon
Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!
Job added to Upwork: https://www.upwork.com/jobs/~021861553347426346949
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)
iOS: https://github.com/user-attachments/assets/5213f865-66e1-4c29-b7d4-fa43123c7c73
@twisterdotcom, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?
Triggered auto assignment to @yuwenmemon (AutoAssignerNewDotQuality)
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@yuwenmemon @twisterdotcom @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@yuwenmemon, @twisterdotcom, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@yuwenmemon, @twisterdotcom, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
I have to imagine it's internal given the crash. All of the request IDs in the logs above don't really give us much either:
8e8da90898acef0f-LHR
8e8da69f0fb9ecfe-LHR
8e8da697bcfaecfe-LHR
8e8da6735f2cecfe-LHR
8e8da6692c02ecfe-LHR
They're not for deleting a bank account. It's like the app completely froze when doing that. Will see if we can get a retest for now.
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
I remember I was working on a very similar issue - as two modals are used here something is preventing the one of the modals backdrop host components to be properly removed and as it's transparent it looks like the app is frozen (but it's not, just the transparent backdrop prevents from interacting with the components under). In that issue the rc was different though. I've also found another issue - https://github.com/Expensify/App/issues/48298 - that seems to have the same root cause and the solution used there should work here as well (probably with a slight modification, because it has changed a bit since the solution was implemented)
https://github.com/Expensify/App/blob/d86024e6688326b5c3040a3c752e0b00265389de/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L598-L606
I will test it and if everything works fine I will post a proposal.
That additional change was made because of the restriction for copilot. Should the copilot be able to delete the bank account from the invoices?
Yes, I think it's fine for the copilot to be able to do this. They can even close accounts, so this is far less destructive.
ok, thanks! So it means that just this one line is fine. I tested this solution and it works fine, so I will open a PR for that