Concierge doesn't have an avatar in the unread summary email of expense reports

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @blimpich Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Setup a control workspace with instant submit and auto-reimbursement
2. Have an employee of that workspace create/submit an expense
3. As the approver, comment on the expense report
4. Then approve the report, confirm it’s auto-reimbursed and the sys message from Concierge is added to the expense report.
5. As the submitter, wait 10mins for the unread summary email to be received for the comment added in step 3.

Expected Result:

The unread summary email sent to the expense submitter should include an avatar for the Concierge comment.

Actual Result:

The avatar is missing from the Concierge comment in the email.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859743425112993650
• Upwork Job ID: 1859743425112993650
• Last Price Increase: 2024-11-21

Issue Owner

Current Issue Owner: @MarioExpensify

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[trjExpensify]

Chatting here about the steps.

[trjExpensify]

Applause repro'd in thread!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021859743425112993650

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[trjExpensify]

@allgandalf I have a feeling this might be internal, but not 100% sure.

[allgandalf]

@allgandalf I have a feeling this might be internal, but not 100% sure.

Definitely internal, has to do something with our ESP or the way we configure things

[trjExpensify]

Kewl, making it internal.

[trjExpensify]

Hopefully this will get called out in today's #retain update! CC: @maddylewis

[trjExpensify]

Called out!

[trjExpensify]

Still looking for a volunteer!

[trjExpensify]

@blimpich as this is confirmed backend and we have the steps to repro easily, maybe you fancy it?

[blimpich]

My plate is full at the moment but will put this on my radar 👍

[MarioExpensify]

Hey @trjExpensify, I can take a look at this one!

[trjExpensify]

Perfect, thanks!

[MarioExpensify]

Update

Just a quick update, had to deal with a production bug today so could not focus 100% on this one, I already found where and how the email is sent, not 100% sure why Concierge icon is not appearing, will probably have an update (and possibly PR) tomorrow.

[melvin-bot[bot]]

@trjExpensify @MarioExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MarioExpensify]

Update

Another quick update, I'm still working on this one, I've got a small question regarding the flow in ND (before the summary email hits the user) that I've left in this thread. Now I'm taking a look at how the Concierge avatar is added to the message. I'll keep you posted.

Edit. It seems the message sent to ND comes from the workspace admin, while the email receives the system message from the Concierge, I believe that may be the source of the issue, looking how to fix it:

ND:

Email:

@trjExpensify now, which of these is actually wrong? Is it the ND message that should come from Concierge or the Email notification that should have the system message from the workspace admin?

[trjExpensify]

Chatted it out here!

[melvin-bot[bot]]

@trjExpensify, @MarioExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MarioExpensify]

Update

Hey, no updates during the weekend, sorry 😅 . I already started working on how to change the email to stop using Concierge account as "sender" for the sys message. Expecting to have a PR ready for review Today if this is the only flow affected.

[trjExpensify]

Love it, appreciate the update!

[MarioExpensify]

Update

Still working on this one, I thought I had the fix already but after the test the problem persists. The testing of this issue locally takes some time as sometimes the email takes more than 10 minutes to arrive so I'm multitasking a little. Will have this wrapped up soon.

[melvin-bot[bot]]

@trjExpensify, @MarioExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MarioExpensify]

Update

PR on its way (finally!) - Testing locally and updating unit/integration tests before wrapping up.

[MarioExpensify]

PR is ready for review!

[MarioExpensify]

Deployed to production. Waiting for any regressions then we can close thise.