Workspace chats are pinned in LHN for archived workspace

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @flodnv Slack conversation (hyperlinked to channel name): ts_external_expensify_migrate

Action Performed:

1. Login as a expelled member of workspace
2. Observe LHN

Expected Result:

we should be:

• creating the workspace chat (which will pin it)
• adding all the report previews to the workspace chat
• archiving the workspace chat (which should unpin it)

Actual Result:

We aren't archiving the workspace chat (which should unpin it)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MonilBhavsar

[melvin-bot[bot]]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[flodnv]

I think this is part of the #migrate project, right @puneetlath ?

[garrettmknight]

OP updated, I'm betting this is internal.

[puneetlath]

To be clear I think this is an issue with the MigratePolicies historical report migration. This is a workspace that Florent is no longer a member of. So in theory the workspace chat should be archived and unpinned. But it is not showing as archived or unpinned. So whoever looks into this should look into why that migration isn't archiving the workspace chat for people who are no longer a member of the migrated policy.

FYI @flaviadefaria I made it a hot pick.

[melvin-bot[bot]]

@garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[garrettmknight]

Dropping to weekly while we find a volunteer.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[flaviadefaria]

I'm switching this to daily so we can have more #urgency in getting someone assigned. I also plan to re-test this when we run a next migration test today/tomorrow.

[melvin-bot[bot]]

@garrettmknight this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[garrettmknight]

Still awaiting a volunteer, but hopefully this has been solved and we'll find out in KI tests + Fla's migration tests.

[flaviadefaria]

I tested this in the migration and it's still happening. Whoever picks this up, I'm happy to share more details if needed.

Employee: [email protected]

#admins room displayed as archived despite the user never being an admin (logs) - when clicked it disappeared

This looks like the workspace I created which was briefly called that before I renamed it:

Workspace chat displayed despite archived:

Admin side: [email protected]

[flaviadefaria]

• when clicked it disappeared

Oh actually the archived #admins chat displays again after I sign in again:

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[flaviadefaria]

Issue not reproducible during KI retests. (Second week)

This is only reproducible with accounts migrated from Classic to NewDot

[flaviadefaria]

Reproducible steps:

1. User A creates a new workspace
2. Invites user B with the role "user"
3. User B submits a report to User A
4. User A approves and marks the report as reimbursed
5. User A removes user B from the workspace
6. Run the migration (Ask @puneetlath to run the migration on Users A and B accounts).

Once the migration has run sign in to User A's account and you should be redirected to NewDot and see some of the issues. sign in to User B's account and you'll see the remaining issues.

[MonilBhavsar]

Thanks! @puneetlath is it possible to run migration on dev? Is it script/manual/BulkNudgeToNewExpensify.php?

[puneetlath]

@MonilBhavsar yes! That's the one.

[flaviadefaria]

Sorry, I made a bit of a confusion here... the issue in the OP I actually couldn't recreate. So I'm going to close this GH and open a new one for the two issues that I did experience related to archived chats.