App icon indicating copy to clipboard operation
App copied to clipboard

[vip-travel] Create Trip Details Screen

Open blazejkustra opened this issue 3 months ago • 36 comments

Explanation of Change

We're adding a new Trip Details Modal in NewDot, allowing users to view travel details directly in the app instead of being redirected to Spotnana. This includes creating a new page and components to display trip information like flights, hotels, rails and cars seamlessly.

Fixed Issues

$ https://github.com/Expensify/App/issues/37823 PROPOSAL: N/A

Tests


To prepare your account and environment for testing, follow these steps:

1. Configure Your Account for Testing

  • Navigate to OldDot (ideally create new account)

  • Run the following JavaScript snippet in the console before enabling travel in the account:

    var settings = NVP.get('travelSettings') || {};
    settings.testAccount = true;
    NVP.set('travelSettings', settings);
    
  • Verify that the test settings are successfully applied (NVP.get('travelSettings')).

  • Now you can enable travel in the account and proceed with testing (Search -> Trip -> book a trip)

  • Use stripe card ending in 4444 for testing purposes (https://docs.stripe.com/testing)

  • When reserving trips for testing purposes:

    • Always book trips scheduled at least 1 month in the future.
  • Example:

    • Flight: One-way trip from SEA (Seattle) to SFO (San Francisco).
    • Airline: Alaska Airlines.
    • Departure Date: At least 1 month from the current date.

Flight Details

  • Verify the page displays key information: departure/arrival times, duration of the flight, layovers, airline, seat, record locator, and cabin class.
  • Validate clickable actions: Modify trip and Trip support .
  • Ensure responsive design and alignment across devices.

Hotel Details

  • Confirm correct display of hotel name, address, check-in/out times, room type, and cancellation policy.
  • Check clickable actions: Modify trip and Trip support .
  • Verify overall layout for completeness and responsiveness.

Car Rental Details

  • Check the car rental name, pickup/drop-off details, car type, and cancellation policy.
  • Ensure the Modify trip and Trip support options are functional.
  • Validate formatting and responsiveness across devices.

Train/Rail Details

  • Verify the page displays key information: departure/arrival times, duration of the ride, layovers, airline, seat, record locator, and cabin class.
  • Validate clickable actions: Modify trip and Trip support .
  • Ensure responsive design and alignment across devices.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

  • [x] I linked the correct issue in the ### Fixed Issues section above
  • [x] I wrote clear testing steps that cover the changes made in this PR
    • [x] I added steps for local testing in the Tests section
    • [x] I added steps for the expected offline behavior in the Offline steps section
    • [x] I added steps for Staging and/or Production testing in the QA steps section
    • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I ran the tests on all platforms & verified they passed on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • [x] I followed proper code patterns (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I followed the guidelines as stated in the Review Guidelines
  • [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [x] I verified that if a function's arguments changed that all usages have also been updated correctly
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-web.webm

iOS: Native

https://github.com/user-attachments/assets/1b882e5a-93b0-43ac-834b-c152df9ee4ee

iOS: mWeb Safari

Nothing here 🤫

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/237b45c2-b36d-4fa5-a13e-e26089fefe63

MacOS: Desktop

https://github.com/user-attachments/assets/3b68289b-cf28-41d6-8b66-60415106dfbe

blazejkustra avatar Nov 20 '24 14:11 blazejkustra