[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-03] Clean up card assignment when only one member and/or card

[joekaufmanexpensify]

Coming from here, if you assign a third party card now on a workspace with only one member and/or card, you have to manually select the member and the card. This is unnecessary because the member will always see the card being assigned and to whom on the confirmation page Let's update this so:

• If there's one workspace member, we select them automatically (skipping the step) and land directly on the card selection.
• If there's multiple workspace members, but only one card, after selecting a member, we select the card automatically (skipping the step) and landing on the start date.
• If there's one workspace member AND one card, automatically select the member and card (skipping both steps) and land directly on the transaction start date.

cc @mountiny @JmillsExpensify

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot[bot]]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

It sounds like maybe @koko57 will take this one?

[koko57]

looks like I'm the chosen one 😃 yup, taking it!

[joekaufmanexpensify]

TY!

[koko57]

PR opened for review https://github.com/Expensify/App/pull/52871

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.66-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52871

If no regressions arise, payment will be issued on 2024-12-03. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@DylanDylann @kadiealexander @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53200

If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@DylanDylann @kadiealexander @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• Reviewer: @DylanDylann paid $250 via Upwork (LINK)

BugZero Checklist (@kadiealexander)

• [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[mountiny]

@DylanDylann @joekaufmanexpensify Could you please write up and add a regression test for this logic before closing this one? Thanks!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021865953482835499840

[melvin-bot[bot]]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[DylanDylann]

BugZero Checklist:

• [x] [Contributor] Classify the bug:

Bug classification

Source of bug:

• [x] 1a. Result of the original design (eg. a case wasn't considered)
• [ ] 1b. Mistake during implementation
• [ ] 1c. Backend bug
• [ ] 1z. Other:

Where bug was reported:

• [ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• [x] 2b. Reported on staging (eg. found during regression or PR testing)
• [ ] 2d. Reported on a PR
• [ ] 2z. Other:

Who reported the bug:

• [ ] 3a. Expensify user
• [x] 3b. Expensify employee
• [ ] 3c. Contributor
• [ ] 3d. QA
• [ ] 3z. Other:

• [ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: No need because this is new feature

• [ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Ideally 4 workspaces with Company Cards enabled and a feed added Workspace A - 1 member, multiple cards to assign Workspace B - several members, 1 card to assign (if you don't have a workspace with only 1 card you can change this code from) Workspace C - 1 member, 1 card to assign Workspace D - several members, several cards to assign

Test:

• Workspace A

1. Go to Workspace A -> Company Cards -> Assign Card
2. Verify that the Assignee step is skipped, you're on the Card selection step
3. Go to members -> member details -> New Card
4. Verify that the Assignee step is skipped, you're on the Card selection step (the behavior was the same before, it should not change)

• Workspace B

1. Go to Workspace B -> Company Cards -> Assign Card
2. Verify that after choosing Assignee the Card selection step is skipped - you land on the Transaction Start step
3. Go to members -> member details -> New Card
4. Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step

• Workspace C

1. Go to Workspace C -> Company Cards -> Assign Card
2. Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step
3. Go to members -> member details -> New Card
4. Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step

• Workspace D

1. Go to Workspace D -> Company Cards -> Assign Card
2. Verify that you land on the Assignee step like before
3. Go to members -> member details -> New Card
4. Verify that only the Assignee is skipped - you land on the Card selection step

Do we agree 👍 or 👎

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.72-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53550

If no regressions arise, payment will be issued on 2024-12-16. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@DylanDylann @kadiealexander @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $250 via Upwork (LINK)

BugZero Checklist (@kadiealexander)

• [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1865953482835499840/hired)
• [x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [x] I have verified the payment summary above is correct

[kadiealexander]

Regression test: https://github.com/Expensify/Expensify/issues/454327

[DylanDylann]

@kadiealexander I have given full refund for https://github.com/Expensify/App/issues/52820#issuecomment-2544995567.

This will be paid later when the batch of issues I'm working on is completed.