App
App copied to clipboard
Expensify
[HOLD for payment 2024-12-17] [$125] Add "Go to workspace" as a shortcut in all of the workspace chats, rooms and reports details page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.64-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: #convert thread
Action Performed:
- Create a workspace
- Navigate to the #admins room
- Click the header of the chat
Expected Result:
This is a new feature
- Add a
Go to workspacerow in the bottom position of the details screen of all workspace chats, rooms, threads originating from a parentChat associated with a workspace, expense reports and expense transaction threads.
- When clicked, navigate to the workspace settings page. On small screens that'll be the LHN workspace settings page, on large screens that will be the workspace profile page.
Actual Result:
Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.
Workaround:
N/A, improvement.
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Standalone
- [x] Android: HybridApp
- [x] Android: mWeb Chrome
- [x] iOS: Standalone
- [x] iOS: HybridApp
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
In-line above.
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021860062325064165317
- Upwork Job ID: 1860062325064165317
- Last Price Increase: 2024-11-22
- Automatic offers:
- mkzie2 | Contributor | 105028511
Issue Owner
Current Issue Owner: @trjExpensify
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.
Edited by proposal-police: This proposal was edited at 2024-11-20 13:47:59 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users are getting a little lost trying to find their workspace settings, and one of the places they're commonly looking is in the details screen of the chats/reports associated with the workspace. As such, we want to provide a shortcut to get to the workspace settings from there to hopefully help.
What is the root cause of that problem?
This is a new feature
What changes do you think we should make in order to solve the problem?
-
Create a new const here for
Go to workspaceand a translation key forGo to workspace -
Add the
Go to workspaceitem here if thereport?.policyIDisn't fake policyID withactionis a function that we will navigate to the LHN workspace settings page in small screen, navigate to the workspace profile page if it's the large screen.
if (report?.policyID && report?.policyID !== CONST.POLICY.ID_FAKE) {
items.push({
key: CONST.REPORT_DETAILS_MENU_ITEM.GO_TO_WORKSPACE,
translationKey: 'common.goToWorkspace',
icon: Expensicons.Workspace,
action: () => {
if (isSmallScreenWidth) {
Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(report?.policyID));
return;
}
Navigation.navigate(ROUTES.WORKSPACE_PROFILE.getRoute(report?.policyID));
},
isAnonymousAction: false,
shouldShowRightIcon: true,
})
}
https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/ReportDetailsPage.tsx#L520
What alternative solutions did you explore? (Optional)
Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@youssef-lr I am not sure if something else needs to be done. @mkzie2 was assigned the issue but I don't see a GH comment about the assignment + upwork link.
Job added to Upwork: https://www.upwork.com/jobs/~021860062325064165317
Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@trjExpensify Do we always want to keep Go to workspace at the bottom? For example in thread report & transaction thread report:
| Thread | Transaction thread |
|---|---|
Good question! @Expensify/design, what do you think? Breaking up the carets looks a bit weird.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53076
If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @mananjadhav requires payment through NewDot Manual Requests
- @mkzie2 requires payment automatic offer (Contributor)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
@trjExpensify There was a regression on the PR, so it was reverted. The follow-up PR is raised, which I'll finish the checklist on.