App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

[HOLD for payment 2024-12-05] [$250] Workspaces page - Update the New workspace button colour, and add "Go to workspace" to the three dot overflow menu

Open trjExpensify opened this issue 1 year ago • 24 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: v9.0.64-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: #convert thread

Action Performed:

  1. Create a new account on new.expensify.com
  2. Select "Manage my team's expenses"
  3. Complete the onboarding steps
  4. Click "Settings" bottom tab > Workspaces

Expected Result:

This is a new feature

  1. Change the New workspace button to our standard button colour
  2. Add "Go to workspace" to the three dot overflow menu. When clicked, navigate to the workspace settings just like you tapped the whole row.

image

Actual Result:

The button colour is green There's no "Go to workspace" option in the overflow menu.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [x] Android: mWeb Chrome
  • [x] iOS: Standalone
  • [x] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021858960137282592665
  • Upwork Job ID: 1858960137282592665
  • Last Price Increase: 2024-11-19
  • Automatic offers:
    • gijoe0295 | Contributor | 104993249
Issue OwnerCurrent Issue Owner: @trjExpensify

trjExpensify avatar Nov 19 '24 19:11 trjExpensify

Job added to Upwork: https://www.upwork.com/jobs/~021858960137282592665

melvin-bot[bot] avatar Nov 19 '24 19:11 melvin-bot[bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

melvin-bot[bot] avatar Nov 19 '24 19:11 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

melvin-bot[bot] avatar Nov 19 '24 19:11 melvin-bot[bot]

Edited by proposal-police: This proposal was edited at 2024-11-19 19:53:17 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Workspaces page - Update the New workspace button colour, and add "Edit workspace" to the three dot overflow menu

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?


  • Remove success from the button. https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L369
  • Add edit option which will navigate to workspace onSelected just like delete action. https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L161-L172

What alternative solutions did you explore? (Optional)

Result

Krishna2323 avatar Nov 19 '24 19:11 Krishna2323

Edited by proposal-police: This proposal was edited at 2024-11-19 19:54:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the New workspace button colour, and add "Edit workspace" to the three dot overflow menu

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

  1. Remove success prop:

https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L366-L367

  1. In here, check if isAdmin || isOwner and add the edit menu item:

https://github.com/Expensify/App/blob/90e4e00508561db6f8aa18136300ec204351187e/src/pages/workspace/WorkspacesListPage.tsx#L152

threeDotsMenuItems.push({
    icon: Expensicons.Pencil,
    text: translate('workspace.common.goto'),
    onSelected: item.action,
});

gijoe0295 avatar Nov 19 '24 19:11 gijoe0295

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the New workspace button colour, and add "Edit workspace" to the three dot overflow menu

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

  1. Remove success props

https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L369

  1. Add edit menu item

https://github.com/Expensify/App/blob/a73f681f60e940868db253b63234292e00a58f32/src/pages/workspace/WorkspacesListPage.tsx#L180

threeDotsMenuItems.push({
    icon: Expensicons.Pencil,
    text: 'Edit Workspace',
    onSelected: item.action,
});

What alternative solutions did you explore? (Optional)

nkdengineer avatar Nov 19 '24 19:11 nkdengineer

📣 @pablodev07! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Nov 19 '24 23:11 melvin-bot[bot]

@Krishna2323 's initial proposal was a partial solution to the issue (addressing the button color only). They edited their proposal later, but by that time, @gijoe0295 had already posted their proposal.

jayeshmangwani avatar Nov 20 '24 07:11 jayeshmangwani

Lets go with @gijoe0295's Proposal

🎀 👀 🎀 C+ reviewed

jayeshmangwani avatar Nov 20 '24 07:11 jayeshmangwani

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Nov 20 '24 07:11 melvin-bot[bot]

Updated the OP with a new mock based on related Slack threads. Posting the mocks here just for super ultra clarity.

image

image

dannymcclain avatar Nov 20 '24 15:11 dannymcclain

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] avatar Nov 20 '24 18:11 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.67-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/52847

If no regressions arise, payment will be issued on 2024-12-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @jayeshmangwani requires payment through NewDot Manual Requests
  • @gijoe0295 requires payment automatic offer (Contributor)

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@jayeshmangwani] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

This was a new feature, so the bug checklist does not apply here. Instead, I am proposing the following regression test:

Regression Test Proposal

  1. Go to Settings and navigate to Workspaces.
  2. Press the 3-dot icon in the workspace row.
  3. Verify that the Go to Workspace option is displayed.
  4. Verify that pressing it opens the Workspace Settings.

Do we agree 👍 or 👎

jayeshmangwani avatar Dec 04 '24 07:12 jayeshmangwani

Nice, thanks. We have a 3-dot menu test in TestRail here, copied below so you can see it. I think this needs a little refresh. Can you confirm the #announce menu item doesn't show here anymore, and suggest edits that incorporates testing for the new Go to Workspace option? Thanks!

  1. Navigate the workspace settings list with the workspace selector set to the E logo
  2. Click on the three dot menu next to a workspace
  3. Make sure that followings are present "Go to #admins room" and "Go to #announce room"
  4. Click on "Go to #admins room"
  5. Verify you're navigated to the #admins room of the workspace and the LHN displays the #admins report
  6. Navigate to any other report
  7. Verify that the #admins report is not shown in LHN
  8. Repeat steps 1 to 3 and navigate back to #admins room
  9. Leave a comment in #admins room and navigate to any other report.
  10. Verify that the #admins report remains shown and does not hide anymore.
  11. Repeat steps 1 to 3
  12. Click on "Go to #announce room"
  13. Verify you're navigated to the #announce room of the workspace

trjExpensify avatar Dec 04 '24 11:12 trjExpensify

I think this needs a little refresh. Can you confirm the #announce menu item doesn't show here anymore

@trjExpensify For older workspaces, I can still see the 'Go to #announce room' option, but it doesn't seem to be available in workspaces created today. Screenshot 2024-12-04 at 16 57 51

jayeshmangwani avatar Dec 04 '24 11:12 jayeshmangwani

@trjExpensify IMO, we can update the regression test to include the two new options: 'Go to workspace' and 'Delete workspace' These options should only be visible to admins or workspace owners.

For non-admin users, they won't have the 'Delete workspace' or 'Go to #admins room' options. Instead, they'll see the 'Leave' option. For these specific cases involving non-admins, do we need a separate regression test, or can we incorporate these scenarios into the existing TestRail?

non-admin user's options Screenshot 2024-12-04 at 17 05 41

jayeshmangwani avatar Dec 04 '24 11:12 jayeshmangwani

@trjExpensify For older workspaces, I can still see the 'Go to #announce room' option, but it doesn't seem to be available in workspaces created today.

Cool, and what about if you add 3+ members to that new workspace. Does it then show?

@trjExpensify IMO, we can update the regression test to include the two new options: 'Go to workspace' and 'Delete workspace' These options should only be visible to admins or workspace owners.

Yikes, Delete workspace should only be shown to a workspace owner. Can a non-owner admin actually delete the workspace?

For non-admin users, they won't have the 'Delete workspace' or 'Go to #admins room' options. Instead, they'll see the 'Leave' option. For these specific cases involving non-admins, do we need a separate regression test, or can we incorporate these scenarios into the existing TestRail?

We can add them in the same test case, with different headers for the scenarios.

trjExpensify avatar Dec 04 '24 11:12 trjExpensify

Cool, and what about if you add 3+ members to that new workspace. Does it then show?

Ohh, yes it shows for 3+ members 🤦

jayeshmangwani avatar Dec 04 '24 11:12 jayeshmangwani

Yikes, Delete workspace should only be shown to a workspace owner. Can a non-owner admin actually delete the workspace?

yes you're right, owner only can see the Delete option and non-owner admin cannot see/delete the workspace

jayeshmangwani avatar Dec 04 '24 11:12 jayeshmangwani

1. Precondition: User is the owner of the workspace

  1. Navigate the workspace settings list with the workspace selector set to the E logo
  2. Click on the three-dot menu next to a workspace.
  3. Ensure the following options are present:
  • "Go to workspace"
  • "Delete workspace"
  • "Go to #admins room"
  • If the workspace has more than 3 participants, "Go to #announce room" should also be visible.
  1. Click on "Go to workspace."
  2. Verify that clicking it opens the Workspace Settings page.
  3. Click on "Delete workspace."
  4. Verify that the Delete Workspace confirmation modal appears.
  5. In the modal:
  • Confirm that clicking "Delete" deletes the workspace.
  • Confirm that clicking "Cancel" closes the modal without any changes.
  1. Click on "Go to #admins room"
  2. Verify you're navigated to the #admins room of the workspace and the LHN displays the #admins report
  3. Navigate to any other report
  4. Verify that the #admins report is not shown in LHN
  5. Repeat steps 1 to 3 and navigate back to #admins room
  6. Leave a comment in #admins room and navigate to any other report.
  7. Verify that the #admins report remains shown and does not hide anymore.
  8. Repeat steps 1 to 3
  9. Click on "Go to #announce room"
  10. Verify you're navigated to the #announce room of the workspace

2. Precondition: User is an admin of the workspace

  1. Navigate the workspace settings list with the workspace selector set to the E logo
  2. Click on the three-dot menu next to a workspace.
  3. Ensure the following options are present:
  • "Go to workspace"
  • "Go to #admins room"
  • If the workspace has more than 3 participants, "Go to #announce room" should also be visible.
  1. Click on "Go to workspace."
  2. Verify that clicking it opens the Workspace Settings page.
  3. Click on "Go to #admins room"
  4. Verify you're navigated to the #admins room of the workspace and the LHN displays the #admins report
  5. Navigate to any other report
  6. Verify that the #admins report is not shown in LHN
  7. Repeat steps 1 to 3 and navigate back to #admins room
  8. Leave a comment in #admins room and navigate to any other report.
  9. Verify that the #admins report remains shown and does not hide anymore.
  10. Repeat steps 1 to 3
  11. Click on "Go to #announce room"
  12. Verify you're navigated to the #announce room of the workspace

3. Precondition: User is a member of the workspace

  1. Navigate the workspace settings list with the workspace selector set to the E logo
  2. Click on the three-dot menu next to a workspace.
  3. Ensure the following options are present:
  • "Go to workspace"
  • "Leave"
  • If the workspace has more than 3 participants, "Go to #announce room" should also be visible.
  1. Click on "Go to workspace."
  2. Verify that clicking it opens the Workspace Settings page.
  3. Click on "Leave"
  4. Verify that the workspace is no longer visible in the workspaces list.
  5. Repeat steps 1 to 3
  6. Click on "Go to #announce room"
  7. Verify you're navigated to the #announce room of the workspace

jayeshmangwani avatar Dec 04 '24 13:12 jayeshmangwani

@trjExpensify, please have a look on this regression test it seems fairly detailed. Let me know if there's anything else that needs to be included here.

jayeshmangwani avatar Dec 04 '24 13:12 jayeshmangwani

Excellent! I've created an issue for Applause!

Payment summary as follows:

  • $250 to @jayeshmangwani for the C+ review (go ahead and request!)
  • $250 to @gijoe0295 for the fix (paid!)

Settled up, closing!

trjExpensify avatar Dec 05 '24 11:12 trjExpensify

$250 approved for @jayeshmangwani

garrettmknight avatar Dec 12 '24 11:12 garrettmknight