App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Hold - Held expense is lost when individual partially pay the report

Open IuliiaHerets opened this issue 1 year ago • 15 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.64-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5238586&group_by=cases:section_id&group_id=309128&group_order=asc Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. User A creates 2 expenses to User B
  2. User B opens the report and hold the first expense
  3. User B pay elsewhere partially the report
  4. User A and User B go to the main chat

Expected Result:

Held expense should be present at the bottom of the page

Actual Result:

Held expense is lost when individual partially pay the report/User must switch chat to reapear

Workaround:

Unknown

Platforms:

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [x] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/368c030e-e144-4655-82a6-af219e54b229

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859644564044218290
  • Upwork Job ID: 1859644564044218290
  • Last Price Increase: 2024-12-05

IuliiaHerets avatar Nov 19 '24 12:11 IuliiaHerets

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 19 '24 12:11 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859644564044218290

melvin-bot[bot] avatar Nov 21 '24 17:11 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

melvin-bot[bot] avatar Nov 21 '24 17:11 melvin-bot[bot]

@suneox, @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 25 '24 09:11 melvin-bot[bot]

We’re still looking for proposals

suneox avatar Nov 25 '24 15:11 suneox

It's not reproducible.

jacobkim9881 avatar Nov 25 '24 20:11 jacobkim9881

It's not reproducible.

@jacobkim9881 Thanks for your feedback. This issue can not reproduce on latest staging so we can retest then close this issue

https://github.com/user-attachments/assets/d533376f-ce6b-4a78-a399-c4e37c8e42eb

suneox avatar Nov 26 '24 15:11 suneox

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Nov 28 '24 16:11 melvin-bot[bot]

@suneox Thanks for reviewing. Let me check my solution.

jacobkim9881 avatar Nov 28 '24 20:11 jacobkim9881

The issue is not reproducible. Waiting for retest and close

suneox avatar Dec 02 '24 06:12 suneox

@suneox, @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 05 '24 09:12 melvin-bot[bot]

added the retest label

sonialiap avatar Dec 05 '24 12:12 sonialiap

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 05 '24 16:12 melvin-bot[bot]

@suneox, @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 09 '24 09:12 melvin-bot[bot]

waiting for the weekly retest

sonialiap avatar Dec 09 '24 13:12 sonialiap

posted a request for retest in slack

sonialiap avatar Dec 12 '24 11:12 sonialiap

This issue is repro only on submitter's side. User A must switch chat for held expense to reappear

https://github.com/user-attachments/assets/36ab5b3e-5574-422f-be5d-c05db380a16d

izarutskaya avatar Dec 12 '24 12:12 izarutskaya

Thanks Irina! I've updated the repo steps

sonialiap avatar Dec 12 '24 12:12 sonialiap

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 12 '24 16:12 melvin-bot[bot]

I'm OOO Dec 16-20 but I don't think this will need a BZ while I'm out so not adding a leave buddy

sonialiap avatar Dec 13 '24 12:12 sonialiap

Internal issue as this requires Pusher updates to be sent correctly.

🎀👀🎀 C+ reviewed

shubham1206agra avatar Dec 13 '24 13:12 shubham1206agra

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Dec 13 '24 13:12 melvin-bot[bot]

@suneox Fastracked the review for you

shubham1206agra avatar Dec 13 '24 13:12 shubham1206agra

@suneox Fastracked the review for you

I'd like to confirmed that this issue can reproducible at step 3.

https://github.com/user-attachments/assets/71f4377c-08b4-4e3d-929e-3fffdfa37b0a

It doesn’t occur at step 4, so I think we should remove step 4 from the action performed.

https://github.com/user-attachments/assets/5261cbec-c639-4fe8-88ec-39c9598a43a1

suneox avatar Dec 13 '24 16:12 suneox

@suneox @sonialiap @thienlnam this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Dec 17 '24 09:12 melvin-bot[bot]

We're still looking for proposals on this issue. I’ve posted it to Slack to get more attention

suneox avatar Dec 17 '24 09:12 suneox

@suneox, @sonialiap, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 17 '24 09:12 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 19 '24 16:12 melvin-bot[bot]

@suneox, @sonialiap, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 20 '24 09:12 melvin-bot[bot]

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 21 '24 02:12 mvtglobally