App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Report waiting for approval shows in OldDot but not in NewDot

Open m-natarajan opened this issue 1 year ago • 18 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Need reproduction Reproducible in production?: Need reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @saracouto Slack conversation (hyperlinked to channel name): Expensify Bug

Action Performed:

  1. Have a employee to submit a report
  2. As a approver login to OldDot and ensure the report is pending for approval
  3. Log in to NewDot and look for the same report

Expected Result:

Report should be showing in the NewDot

Actual Result:

Does not appear until a comment is left in OldDot

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859629708543110385
  • Upwork Job ID: 1859629708543110385
  • Last Price Increase: 2024-11-21
Issue OwnerCurrent Issue Owner: @saracouto

m-natarajan avatar Nov 18 '24 21:11 m-natarajan

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 18 '24 21:11 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Nov 18 '24 21:11 MelvinBot

Job added to Upwork: https://www.upwork.com/jobs/~021859629708543110385

melvin-bot[bot] avatar Nov 21 '24 16:11 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

melvin-bot[bot] avatar Nov 21 '24 16:11 melvin-bot[bot]

@sakluger do you know if this user has workspace chat enabled? If not, then the report shouldn't show in NewDot.

flaviadefaria avatar Nov 21 '24 17:11 flaviadefaria

@flaviadefaria here's the bug report from @saracouto. She said that this happened in the Contractor policy, which is fully migrated according to that Slack thread.

sakluger avatar Nov 22 '24 16:11 sakluger

@sakluger, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 25 '24 09:11 melvin-bot[bot]

No proposals yet.

sakluger avatar Nov 25 '24 16:11 sakluger

Hello, I'm Zuza from Software Mansion agency and I can take care of this issue 😊

zfurtak avatar Nov 26 '24 10:11 zfurtak

I was trying to reproduce this issue (video below) but I couldn't. However I'm not sure if I'm testing the right flow 🤔 Could you add more specific reproduction steps or ideally a video?

https://github.com/user-attachments/assets/187ed69b-14c0-4fdd-b79d-0b9d1b898273

image

zfurtak avatar Nov 27 '24 11:11 zfurtak

Thanks @zfurtak!

@saracouto - Since you were the one who reported this issue, I've assigned you to help verify reproduction steps. Could you please check this comment and see if any steps are wrong or missing in the reproduction video? Feel free to unassign after responding.

sakluger avatar Nov 27 '24 19:11 sakluger

@sakluger @saracouto @parasharrajat @zfurtak this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 02 '24 09:12 melvin-bot[bot]

I don't have any current report in that situation. Once I do, I'll post/report here. If I don't see anything weird in a couple weeks, I'll close this one out!

saracouto avatar Dec 02 '24 22:12 saracouto

Ok, I think I just ran into this situation again. @blimpich submitted these two expenses and I got the email notification and I can see it in old.dot:

image image image

However, I don't see it under the LHN in new.dot: image

saracouto avatar Dec 04 '24 13:12 saracouto

Unassigning myself but let me know if you need anything else!

saracouto avatar Dec 05 '24 14:12 saracouto

@zfurtak let us know if this is helpful as this is a critical issue for us. I'll also try to reproduce it in my test account tomorrow morning.

flaviadefaria avatar Dec 05 '24 20:12 flaviadefaria

@zfurtak are you still planning to work on this? This is a blocker for our launch so we'd appreciate if you could give us an update asap - thanks!

PS: I'll also try to reproduce this in my test account today.

flaviadefaria avatar Dec 09 '24 12:12 flaviadefaria

Hello, I'm currently trying to reproduce this bug but so far I couldn't do it, let me know if you came across this bug on you account. It would be great to have more specific reproduction steps, maybe I'm missing something 🤔

Here's how it looks for me on mail: image in the app: image

zfurtak avatar Dec 09 '24 12:12 zfurtak

I noticed this happened again on my end:

OldDot: image

NewDot: Just Matt's report is showing up: image

saracouto avatar Dec 09 '24 15:12 saracouto

@zfurtak is there any other information that @saracouto could provide you? Would it help if she exported the Onyx state?

sakluger avatar Dec 09 '24 15:12 sakluger

Could you please confirm the type of workspace setup used here? Specifically, is it managed through the Workspace -> Workflows -> Add Approvals? Additionally, I understand from the Slack discussion that this involves the US Contractors policy. Could you tell me how to access it? Thank you 😊

zfurtak avatar Dec 10 '24 15:12 zfurtak

@saracouto some questions from me:

  • Do you know if these reports from @blimpich were created in Classic or ND?
  • Do you know if these reports from @blimpich were submitted in Classic or ND?

Thanks!

flaviadefaria avatar Dec 10 '24 17:12 flaviadefaria

I also couldn't recreate this:

image image

flaviadefaria avatar Dec 10 '24 17:12 flaviadefaria

@saracouto some questions from me:

  • Do you know if these reports from @blimpich were created in Classic or ND?
  • Do you know if these reports from @blimpich were submitted in Classic or ND?

Thanks!

Both were created and submitted in NewDot.

blimpich avatar Dec 10 '24 17:12 blimpich

@blimpich one more question, are you in the Contractors or US policy?

flaviadefaria avatar Dec 10 '24 18:12 flaviadefaria

US policy

blimpich avatar Dec 10 '24 18:12 blimpich

Thanks for confirming @blimpich! I chatted with @puneetlath and it looks like the US workspace was only partially migrated so I'll close this issue until we finish migrating it and this might get automatically fixed then.

flaviadefaria avatar Dec 10 '24 18:12 flaviadefaria