App
App copied to clipboard
Expensify
We created multiple workspaces for user in onboarding
This is being discussed here so I'm just creating a tracking issue for us to get to the bottom of it with @marcaaron @trjExpensify
https://expensify.slack.com/archives/C07HPDRELLD/p1731537294677189
I think @carlosmiceli is working on moving the policy creation to the CreateAccount step. I am wondering if this is at all related to those changes. At least, it seems like it will be fixed by them since we will no longer be creating the policy via an API call triggered in App.
Interesting. Carlos, how does that work if you create an account on new.expensify.com directly where there's no signUpQualifiers to choose? 🤔
What @marcaaron says is correct, that's what I'm working on. @trjExpensify so far, we would just not create a workspace for any signup that hasn't selected a qualifier. In fact, creating an account will not fail if for some reason the workspace fails to get created. But let's check with @anmurali to see if we'd like to add/change some logic about it.
@trjExpensify so far, we would just not create a workspace for any signup that hasn't selected a qualifier
Okay, which means they would then see the onboarding modal and selecting the manage my team path would create a workspace?
Oh, that's a good question (and sounds like a good idea) but I don't know about that being discussed anywhere and it's definitely outside of the scope of the issue I'm working on (which is all BE and happening before ND is loaded).
Sorry, maybe I'm not explaining myself well.
- You said you're working on creating a workspace after you choose this on the expensify.com home page:
- Today, the timing of creating the workspace is after you click this:
Q: In the expensify.com sign-up flow, how are you avoiding creating two workspaces on sign-up? Are you skipping that "How many employees do you have?" screen, and as a result, not triggering the CreateWorkspace command a second time?
Q: If you sign-up via new.expensify.com where there are no signUpQualifiers to select on the home page, will you still see the "How many employees do you have?" screen if you choose "Manage my team's expenses" in the first step, and thus still trigger CreateWorkspace at that point like today?
In the expensify.com sign-up flow, how are you avoiding creating two workspaces on sign-up? Are you skipping that "How many employees do you have?" screen, and as a result, not triggering the CreateWorkspace command a second time?
I haven't got to this point yet, but I think as Marc said, we're going to remove the current CreateWorkspace logic of creating the policy in App during onboarding (at least temporarily so we don't create duplicates).
If you sign-up via new.expensify.com where there are no signUpQualifiers to select on the home page, will you still see the "How many employees do you have?" screen if you choose "Manage my team's expenses" in the first step, and thus still trigger CreateWorkspace at that point like today?
To clarify, I'm not working in anything that would change any logic that happens after/during signup through new.expensify.com, other than replacing the logic as I mentioned above. You will see whatever you see while signing up now. This means that no workspace will get created when signing up through new.expensify.com until we actually want to implement some logic around that.
I hope I'm understanding the question 😅
Got it, so yeah.. if you remove the logic to create a workspace in the onboarding modal completely, you're going to break creating a workspace during onboarding for:
- a sign-up on new.expensify.com on web/mWeb
- a sign-up on the New Expensify mobile app (we're going to deprecate it soon, but still worth noting)
- a sign-up on the native Expensify mobile app because that mobile home page also does not have signUpQualifiers (we're about to start defaulting new account sign-ups in NewDot after the next release that's on the way out the door)
So I don't think we should remove it completely. Rather, if you come from expensify.com or use.expensify.com and a workspace is created for you because of the signUpQualifier selection, we skip the "How many employees do you have?" screen and creating a workspace on completion of the onboarding step. If you don't have a signUpQualifier selection, we show it and create a workspace like today.
Ah, gotcha! Yup, that sounds good, we can do that. By the way, while it's an edge case, we should consider this again then. I think with this new situation, it's justified to just hide the back button instead of having to implement more complicated logic to skip the workspace creation if they happen to go back.
Hm, but isn't that logic going to exist anyway? As in, we won't show the employee count selector screen if they've chosen a signUpQualifier on sign-up? So regardless of if they go back and forward again, the page that triggers the CreateWorkspace command won't show to them.
You asked above "Are you skipping that "How many employees do you have?" screen, and as a result, not triggering the CreateWorkspace command a second time?", so I interpreted that clicking Continue in that screen is what triggered CreateWorkspace. Also, I checked just now and you can still go back to the first screen of the onboarding modal (where they choose objectives), so if instead that's the user choice that triggers CreateWorkspace then more of a reason to hide the back button.
@danielrvidal Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
so I interpreted that clicking Continue in that screen is what triggered CreateWorkspace.
Correct, that's my understanding as well. But if the page is skipped, meaning it doesn't show at all for this use-case, then going back/forward doesn't matter does it? They'll never see that "employee count" page and therefore no Continue button to trigger creating a workspace. So it's not clear to me why we need to restrict going back..
Right, what I'm saying is that, currently, after a user signups and skips those screens and sees the accounting software screen in the onboarding modal, they can go back clicking on the top left of the modal and go back to the employee count. It's not skipped in terms of being hidden, but just being taken straight to the software sections; all previous sections can still be seen if navigating back.
Probably, but not sure how to do that since I haven't worked on that logic, that's probably a good question for someone with more knowledge there. Maybe @tgolen has some advice here? I still think hiding the back button is way easier, though 😅
Actually, thinking deeper about it, it's more future proof to hide the screens as you suggest, in case we keep expanding the onboarding steps.
@danielrvidal Whoops! This issue is 2 days overdue. Let's get this updated quick!
Will create issue today to align the ND fix with the BE work for https://github.com/Expensify/Expensify/issues/437845
@danielrvidal Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Still being worked on, I'm going to move it to weekly since it's just a tracking issue for more urgent issues.
@danielrvidal Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@carlosmiceli where are we at with this one? Still waiting on this to be done? https://github.com/Expensify/App/issues/53326