App icon indicating copy to clipboard operation
App copied to clipboard

No GBR on WS Chat for approver after Take Control + Approve/Forward from admin in OldDot

Open garrettmknight opened this issue 1 year ago • 7 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: N/A Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: N/A Issue reported by: @saracouto Slack conversation (hyperlinked to channel name): #expense

Action Performed:

  1. Create an OldDot workspace, invite Submitter + Approver A, enable Advanced Approvals, set approval asl Submitter > Approver A
  2. As submitter, create expense in your WS chat and submit to Approver A
  3. As admin, open the report and take control
  4. As admin, approve/forward back to Approver A in OldDot

Expected Result:

Approver A should see GBR on Submitters WS chat for the report

Actual Result:

Approver A doesn't see GBR on Submitters WS chat for the report

Workaround:

Approver A can go find the report in WS chat, but only if they know it's waiting on them

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

garrettmknight avatar Nov 05 '24 14:11 garrettmknight

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 05 '24 14:11 melvin-bot[bot]

@puneetlath 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Nov 13 '24 09:11 melvin-bot[bot]

this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Nov 19 '24 09:11 melvin-bot[bot]

Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Nov 19 '24 09:11 melvin-bot[bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Nov 21 '24 09:11 melvin-bot[bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 04 '24 15:12 melvin-bot[bot]

Looks like this one has been unassigned for a while, so I will work on re-triaging this to confirm it still exists!

joekaufmanexpensify avatar Dec 06 '24 22:12 joekaufmanexpensify

Not overdue

joekaufmanexpensify avatar Dec 09 '24 15:12 joekaufmanexpensify

I just triaged this and we do seem to show the approver the GBR on the submitters workspaces chat now!

I submitted a report from [email protected] to [email protected]. Then, as [email protected], I took over the report in OldDot and approved and forwarded it back to [email protected].

image

I then signed into [email protected] and see the GBR in the LHN of the workspace chat to action the approval.

image image

joekaufmanexpensify avatar Dec 11 '24 16:12 joekaufmanexpensify

Going to close this out, as it appears to be fixed. LMK if anything else is needed!

joekaufmanexpensify avatar Dec 11 '24 16:12 joekaufmanexpensify