App icon indicating copy to clipboard operation
App copied to clipboard

[Workspace feed] When accounting integration is connected, there's no default in the card export row. It should be "Default card"

Open m-natarajan opened this issue 1 year ago • 4 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Prerequisite: Members and company cards added in workspace

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details

Expected Result:

When accounting integration is connected, there's default card in the card export row.

Actual Result:

When accounting integration is connected, there's no default card in the card export row.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2024-10-31T153332 628 image - 2024-10-31T153331 634 image - 2024-10-31T153318 519

View all open jobs on GitHub

m-natarajan avatar Nov 01 '24 18:11 m-natarajan

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 01 '24 18:11 melvin-bot[bot]

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

m-natarajan avatar Nov 01 '24 18:11 m-natarajan

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Nov 01 '24 18:11 MelvinBot

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

melvin-bot[bot] avatar Nov 01 '24 20:11 melvin-bot[bot]

added to the project

mountiny avatar Nov 04 '24 13:11 mountiny

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

narefyev91 avatar Nov 05 '24 10:11 narefyev91

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Nov 14 '24 00:11 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.61-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/52180

If no regressions arise, payment will be issued on 2024-11-21. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @narefyev91 does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Nov 14 '24 00:11 melvin-bot[bot]

@DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Nov 14 '24 00:11 melvin-bot[bot]

@joekaufmanexpensify Before going to the PR, could you please clarify the expectation for this issue?

Current behavior

https://github.com/user-attachments/assets/a81b1be8-7f5e-473c-883f-69188d2e99ba

Expect behavior (Changing "Cash and cash equivalents" to "Default Card")

https://github.com/user-attachments/assets/4f428165-f46a-4303-9eea-2a84ea1b21f1

cc @narefyev91

DylanDylann avatar Nov 18 '24 08:11 DylanDylann

Left thoughts here.

joekaufmanexpensify avatar Nov 19 '24 13:11 joekaufmanexpensify

Should I be paying @DylanDylann out, or is this not actually fixed?

twisterdotcom avatar Nov 21 '24 08:11 twisterdotcom

Payment Summary

Upwork Job

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

  • [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [ ] I have verified the payment summary above is correct

melvin-bot[bot] avatar Nov 21 '24 09:11 melvin-bot[bot]

The PR still be reviewing

DylanDylann avatar Nov 21 '24 09:11 DylanDylann

@twisterdotcom, @narefyev91, @mountiny, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 28 '24 09:11 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.67-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/52575

If no regressions arise, payment will be issued on 2024-12-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @narefyev91 does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

@DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

@DylanDylann can you please add a checklist?

mountiny avatar Nov 29 '24 10:11 mountiny

BugZero Checklist:

  • [x] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [x] 1a. Result of the original design (eg. a case wasn't considered)
  • [ ] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [ ] 2a. Reported on production
  • [x] 2b. Reported on staging (deploy blocker)
  • [ ] 2c. Reported on both staging and production
  • [ ] 2d. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [x] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [ ] 3d. QA
  • [ ] 3z. Other:
  • [ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: No because this seems like a case wasn't considered in document

  • [ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [x] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

  1. Choose the workspace from settings
  2. Click company cards >Card Details
  3. Verify that default export account is presented in Export row - with name "Default card"
  4. Click on menu item - Verify that "Default card" is pre-selected -> choose other export account
  5. Verify that selected export account presented in menu item row

Do we agree 👍 or 👎

DylanDylann avatar Dec 01 '24 03:12 DylanDylann

Payment Summary

Upwork Job

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • ROLE: @DylanDylann paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/105224716)

BugZero Checklist (@twisterdotcom)

  • [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [x] I have verified the payment summary above is correct

melvin-bot[bot] avatar Dec 05 '24 09:12 melvin-bot[bot]

Payment Summary:

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • C+: @DylanDylann paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/105224716)

twisterdotcom avatar Dec 06 '24 15:12 twisterdotcom

No need payment here, we will handle payment later

DylanDylann avatar Dec 06 '24 15:12 DylanDylann

Cool, withdrew the one sent above.

twisterdotcom avatar Dec 09 '24 11:12 twisterdotcom