App icon indicating copy to clipboard operation
App copied to clipboard

[Workspace feed] Credit Incorrectly Capitalized in Export Row

Open m-natarajan opened this issue 1 year ago โ€ข 4 comments

If you havenโ€™t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Prerequisite: Members and company cards added in workspace

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details > Export options

Expected Result:

Credit Not Incorrectly Capitalized in Export Row

Actual Result:

Credit Incorrectly Capitalized in Export Row

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2024-10-31T153403 565

image - 2024-10-31T153359 712

View all open jobs on GitHub

m-natarajan avatar Nov 01 '24 18:11 m-natarajan

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 01 '24 18:11 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Nov 01 '24 18:11 MelvinBot

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

m-natarajan avatar Nov 01 '24 18:11 m-natarajan

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

melvin-bot[bot] avatar Nov 01 '24 20:11 melvin-bot[bot]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

narefyev91 avatar Nov 04 '24 08:11 narefyev91

All set @narefyev91 ๐Ÿ‘

slafortune avatar Nov 04 '24 21:11 slafortune

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Nov 07 '24 12:11 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.58-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/51952

If no regressions arise, payment will be issued on 2024-11-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @narefyev91 does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Nov 07 '24 12:11 melvin-bot[bot]

@DylanDylann @slafortune The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Nov 07 '24 12:11 melvin-bot[bot]

PAYMENT SUMMARY FOR OCT 14

  • Fix: @narefyev91 does not require payment
  • PR Review: @DylanDylann [$250, if no regressions] Offer please complete checklist in comment above

abekkala avatar Nov 08 '24 16:11 abekkala

No need payment

cc @mountiny

DylanDylann avatar Nov 09 '24 07:11 DylanDylann

BugZero Checklist:

  • [x] [Contributor] Classify the bug:
Bug classification

Source of bug:

  • [ ] 1a. Result of the original design (eg. a case wasn't considered)
  • [x] 1b. Mistake during implementation
  • [ ] 1c. Backend bug
  • [ ] 1z. Other:

Where bug was reported:

  • [x] 2a. Reported on production
  • [ ] 2b. Reported on staging (deploy blocker)
  • [ ] 2c. Reported on a PR
  • [ ] 2z. Other:

Who reported the bug:

  • [ ] 3a. Expensify user
  • [x] 3b. Expensify employee
  • [ ] 3c. Contributor
  • [ ] 3d. QA
  • [ ] 3z. Other:
  • [x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment:

  • [x] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template
  • [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree ๐Ÿ‘ or ๐Ÿ‘Ž

mountiny avatar Nov 10 '24 23:11 mountiny

No need for regression tests here as its a minor thing. The was handled by the author of the PR, and we just did not notice this in the mocks from the design doc. No payments required.

mountiny avatar Nov 10 '24 23:11 mountiny