[HOLD for payment 2024-12-07] [$250] [NewDot Feature Request] Add route to WS chat in Workspace menu

[garrettmknight]

Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07NMDKEFMH/p1730380892061729

Problem: Many users (like this one) are visibly confused about how to submit expenses for reimbursement to a workspace and find themselves in the Workspace menu during their search.

Solution: Let's add a route in the Workspace details page that navigates to the user's workspace chat for that workspace.

• Start returning the user's WS chat as part of the OpenPolicyInitialPage API call and the OpenPolicyProfilePage API Call since on wide view only the profile one is called.
• Add separator text below WS items in the WS details LHN that reads "Submit expenses using your workspace chat below:"
  • Spanish translation: "Envíe los gastos utilizando el chat de su espacio de trabajo:"
• Add an LHN row that mirrors the look of the user's WS chat in the inbox.
• Selecting the WS chat row in LHN will navigate to the WS chat report for that WS.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854205244452205878
• Upwork Job ID: 1854205244452205878
• Last Price Increase: 2024-11-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot[bot]]

@garrettmknight Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

Still discussing how best to implement.

[garrettmknight]

We've landed on the high level, now we just need to recruit someone to build it!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021854205244452205878

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-11-06 17:15:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add route to WS chat in Workspace menu

What is the root cause of that problem?

This is a new feature request

What changes do you think we should make in order to solve the problem?

1. We should get the policy expense report by filtering from allReports. This will be the policy expense chat that has policyID is the viewing policyID and has isOwnPolicyExpenseChat is true. We can re-use getPolicyExpenseChat function with ownerAccountID is currentUserAccountID and the policyID is the viewing policyID

2. After getting the report, we can add the text and LHN row below the workspace feature here

• The text is the description here

Add separator text below WS items in the WS details LHN that reads "Submit expenses using your workspace chat below:" Spanish translation: "Envíe los gastos utilizando el chat de su espacio de trabajo:"

• The LHN row will contain the avatar of the policy expense chat and the right icon, we can reuse MenuItem component or other component like this. To get the avatar, we can use getIcons function as we did here to get the icon of the policy expense chat. Then when we click on this row, we will navigate to the report screen with the reportID is the ID of the policy expense chat

What alternative solutions did you explore? (Optional)

[garrettmknight]

@shahinyan11 feel free to put a proposal together if you want. If @nkdengineer's isn't complete and yours is we'll assign you.

[shahinyan11]

@garrettmknight Thanks. But @nkdengineer's proposal is good enough. I most likely won't propose.

[s77rt]

@nkdengineer Thanks for the proposal. Overall looks good to me. (ownerAccountID does not have to be currentUserAccountID as employees should see the policy too).

🎀 👀 🎀 C+ reviewed Link to proposal

[melvin-bot[bot]]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[garrettmknight]

Setting this internal and hot pick to get the BE changes completed too.

[melvin-bot[bot]]

@garrettmknight, @s77rt, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

@grgia Can you review the approved proposal https://github.com/Expensify/App/issues/51851#issuecomment-2460730546

[grgia]

Whoops, I thought I already had- all yours @nkdengineer

[nkdengineer]

Thanks, I will raise the PR soon.

[melvin-bot[bot]]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52449

If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[s77rt]

Not a bug ^ No regression test needed

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Reviewer: @s77rt owed $250 via NewDot
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@garrettmknight)

• [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1854205244452205878/hired)
• [x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [x] I have verified the payment summary above is correct

[garrettmknight]

Payment summary:

• Reviewer: @s77rt owed $250 via NewDot - Note that this should have been $125 since there was a regression. I'll reopen this and close when I've confirmed the difference has been applied to another payment.
• Contributor: @nkdengineer $125 - awaiting Upwork profile

[JmillsExpensify]

$250 approved for @s77rt

[garrettmknight]

Dropping to weekly while we work out @nkdengineer's upwork profile.

[nkdengineer]

@garrettmknight My Upwork profile here: https://www.upwork.com/freelancers/~0134d0b74faef1a5ac. I've added this to the GitHub's profile.

[s77rt]

I just remembered this caused a regression and it should be $125.

[garrettmknight]

Thanks for the heads up @s77rt - can you reflect the change on another payment since it's difficult to claw back $$$ via NewDot?

[garrettmknight]

@nkdengineer offer out to you

[s77rt]

Thanks @garrettmknight I have asked for next steps (if possible) here. Otherwise I will deduct this from another payment