App
App copied to clipboard
Expensify
[HOLD for payment 2024-12-07] Create missing upgrade and RHP components
Part of Add Workspace Plan Downgrades to NewDot
Doc section: https://docs.google.com/document/d/1GDPmbvV47VVxucr-tHYjH80VylcJptP0RfGMVy3zanY/edit?tab=t.0#bookmark=id.8wdgvm83nqu6
Steps to complete:
- Locked Plan Type RHP for Subscriptions
- Upgrade Confirmation RHP
- Upgrade Success RHP
Issue Owner
Current Issue Owner: @bfitzexpensify
Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)
@jayeshmangwani Thought I'd create an issue that would gather the final FE aspects of the project, maybe split the PRs a bit in a way that makes sense :)
Let me know if there are any questions!
All good! I'll raise the PR over the weekend. Nothing needed for now, but I'll reach out if anything comes up
Hey @DylanDylann, are you planning to add the Plan Type row in your PR? If you haven’t started on it yet, I can handle it in this issue. While working on the Upgrade Confirmation and Upgrade Success RHP UI, I went ahead and added the route page for Plan Type. Let me know if you’d like me to include it in my PR!
@carlosmiceli Update on this issue: I've created two components:
- Upgrade Confirmation RHP
- Upgrade Success RHP (reusing the existing UpgradeConfirmation component)
The Locked Plan Type RHP is currently in progress.but I’ll wait on merge this issue https://github.com/Expensify/App/issues/51494 first, as it includes the Plan Type page, and they’re very similar.
https://github.com/user-attachments/assets/17e8428c-1b50-4e66-829f-ca9f24d2bbbd
https://github.com/user-attachments/assets/031e29a4-8e1a-45b1-a891-be60e4794a5e
Hi @carlosmiceli @garrettmknight , I have a question regarding the workspace upgrade header title and footer button:
In the doc, the header states Upgrade your workspace and the footer button says Upgrade Workspace. However, we already have an existing Upgrade Workspace page that simply uses Upgrade (screenshot attached below).
Should we use the copies from the design document for the header and footer, or stick with the existing page's text and use that same page with the new upgrade component and benefits bullet points added?
Existing Upgrade:
Design doc:
@jayeshmangwani good questions, I think Garrett will give you the best answer :)
@jayeshmangwani let's use the existing 'Upgrade' button instead of the 'Upgrade Workspace' proposed in the doc.
The BE logic is in review, will notify once it's merged so this can be properly tested.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/52117
If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @jayeshmangwani requires payment through NewDot Manual Requests
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@jayeshmangwani] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [ ] [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Payment Summary
Upwork Job
- Reviewer: @jayeshmangwani owed $250 via NewDot
BugZero Checklist (@bfitzexpensify)
- [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
@jayeshmangwani can you please propose regression steps here and the I'll post the payment summary?
@bfitzexpensify I’m not sure if this issue is ready for payment, as it’s part of the ongoing "Workspace Plan Downgrade" project. The PR is still in progress, and additional PRs will also be part of this project.
Gotcha. @carlosmiceli, how are we handling payment for this project?
@jayeshmangwani once we launch the project we can comb through different issues and PRs and pay out all at once to keep things simple.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing label has been removed, please complete the "BugZero Checklist".