App icon indicating copy to clipboard operation
App copied to clipboard

Chat - Main chat opens when add reply on deleted parent message

Open lanitochka17 opened this issue 1 year ago • 17 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.55-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to any chat
  2. Send a message
  3. Add a reply the the message
  4. From the thread page delete the parent message
  5. Add new reply

Expected Result:

User should remain on thread page when add new reply

Actual Result:

User navigates to main chat when add reply on deleted parent message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/e5d6e179-b6b6-44ef-9817-e82b8380ec90

View all open jobs on GitHub

lanitochka17 avatar Oct 29 '24 13:10 lanitochka17

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Oct 29 '24 13:10 melvin-bot[bot]

This is BE bug the BE is deleting isDeletedParentAction on ADD_COMMENT

"message": [
                        {
                            "html": "",
                            "text": "",
                            "type": "COMMENT",
                            "whisperedTo": []
                        }

and it will set it back on OPEN_REPORT

FitseTLT avatar Oct 29 '24 14:10 FitseTLT

I can repro this one. Going to bring it to #quality to see if someone can pick this up

EDIT: Posted.

jliexpensify avatar Oct 30 '24 01:10 jliexpensify

Bumped the thread for an Engineer.

jliexpensify avatar Nov 03 '24 21:11 jliexpensify

@jliexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Nov 11 '24 15:11 melvin-bot[bot]

Waiting on internal engineer

jliexpensify avatar Nov 12 '24 00:11 jliexpensify

@jliexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Nov 12 '24 09:11 melvin-bot[bot]

Not overdue, waiting on someone to pick it up

jliexpensify avatar Nov 15 '24 02:11 jliexpensify

@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 18 '24 09:11 melvin-bot[bot]

@jliexpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Nov 20 '24 09:11 melvin-bot[bot]

Waiting on internal engineer to pick this up

jliexpensify avatar Nov 20 '24 09:11 jliexpensify

@jliexpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Nov 26 '24 09:11 melvin-bot[bot]

Still waiting

jliexpensify avatar Nov 27 '24 01:11 jliexpensify

@jliexpensify Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 02 '24 09:12 melvin-bot[bot]

@jliexpensify Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Dec 04 '24 09:12 melvin-bot[bot]

Still waiting on someone to pick this up

jliexpensify avatar Dec 04 '24 09:12 jliexpensify

Posted in #expense

jliexpensify avatar Dec 08 '24 22:12 jliexpensify

@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 12 '24 09:12 melvin-bot[bot]

Bumped again

jliexpensify avatar Dec 12 '24 21:12 jliexpensify

@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

Not overdue, I'm OOO until the 29th.

jliexpensify avatar Dec 18 '24 03:12 jliexpensify

@jliexpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 23 '24 09:12 melvin-bot[bot]

@jliexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Dec 25 '24 09:12 melvin-bot[bot]

@jliexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Dec 27 '24 09:12 melvin-bot[bot]

Not overdue.

jliexpensify avatar Dec 29 '24 22:12 jliexpensify

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 30 '24 04:12 mvtglobally

Since Applause cannot repro, lets have them re-test again

jliexpensify avatar Jan 02 '25 04:01 jliexpensify

Waiting on a re-test

jliexpensify avatar Jan 07 '25 03:01 jliexpensify

@jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jan 10 '25 09:01 melvin-bot[bot]

Issue not reproducible during KI retests. (Second week)

mvtglobally avatar Jan 12 '25 05:01 mvtglobally