Expensify
Update New Supportal to differentiate between information that has been intentionally redacted from view and buggy behaviour
Problem: We have a basic version of New Expensify Supportal for viewing user accounts, we need to add new features and improve reliability so that it can be used to support customers and provide demos to prospective new ones.
At the moment, if someone tries to access information in Supportal that has been redacted, all they see is ongoing spinners. This is the same thing we see when there is a bug or issue that is preventing us from viewing information. This is making it very difficult to determine what is working as expected in Supportal, and what is a bug.
Example:
This is a DM and should be redacted (which it is):
This is an expense that I should be able to view, so it appears to be a bug:
Solution: When Supportalled into a customers account, if we try to view information that is purposely redacted, an error should load stating that this information is not available when support logged in. This was discussed here - https://expensify.slack.com/archives/C07NZ8B1VTQ/p1728500635598069
What is redacted?
- Certain chat_types are currently redacted, the PR that removes these chats is here
- The redacted chat logic will be updated soon with this issue
- We also redact virtual card details from the supportal view
Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
Ha, a bug AND new feature. I removed ya @sakluger , I'll snag this as I'm chatting with @stephanieelliott about how manage these. Adding Internal and Daily
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
It's Internal, hot pick and daily. Need to try to find someone to help and/or wait for it to get picked up.
if someone tries to access information in Supportal that has been redacted, all they see is ongoing spinners.
I think we can definitely show a generic error in the case where supportal tries to anything that it shouldn't (we do that in OldDot so a similar solution could be done for NewDot). But would love to understand the root of why access is even attempted in the first place.
Looks like we have logic here to return "nothing" but not to throw any specific error message. Here's one proposal...
Supportal can't access something we can return a specific jsonCode and message like 423 Unable to complete action as support user. Then we can check for the 423 in NewDot and show an alert like:
Does that work for now? cc @thienlnam @danieldoglas
Yeah that's a good idea, we can just have all those flows throw the same error and eventually have an external issue making it pretty if we want
Oh yeah also I think it's 411 Insufficient privileges for OldDot... let's see...
Oh wait no, that is a pretty generic one... I'll come up with something 😄
Hmm so I'm not sure if I understand the premise of this issue after looking into it a bit...
If we can't access the report as a supportal user an error is thrown here and this screen is displayed:
Can someone provide reproduction steps for the exact issue we are trying to solve?
Can someone provide reproduction steps for the exact issue we are trying to solve?
@VictoriaExpensify , can you , since you're way more familiar with supportal and the OP? thx
@mallenexpensify, @marcaaron Still overdue 6 days?! Let's take care of this!
Oof, you know what, Supportal isn't showing the long-loading chats anymore (like I've shown in my initial screenshots). This is kind of a perfect example of why seeing if things have been purposefully redacted/blocked is important. But also makes it hard to reproduce 😅
Regardless, I was going to suggest we put this on hold while this issue is worked:
- [CRITICAL] Update New Supportal to include chat details #51221
That is going to indirectly resolve a lot of these issues because it will be clear when messages and chats are redacted. Once that improvement is made it will be easier to pin-point any screens where it's not clear if info has been redacted and we can decide if this issue needs to be reprioritised.
@mallenexpensify, @marcaaron Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
Asking for an update on the held issue
- https://github.com/Expensify/App/issues/51221#issuecomment-2533330892
Oh this has predominantly been resolved through Marc's work in this issue - https://github.com/Expensify/App/issues/51221#issuecomment-2533330892
Closing this