Expensify
[HOLD for payment 2024-11-20] [$250] Brief loading circle when accessing Company Cards page
Problem
(Discussed here) every time you access the Company cards empty-state page on the workspace, there's a brief loading circle while we render the graphic in the middle of the page. This makes the experience feel less premium, as there isn't any significant amount of data being loaded here. It also doesn't exist for the Expensify Card empty state, which is analogous to this page.
Company cards page
https://github.com/user-attachments/assets/e5cb423e-5fc7-4ec9-a763-1fc4523378e4
Expensify Card page
https://github.com/user-attachments/assets/192b40bb-6a4c-4a9b-a677-9a511aa1326d
Solution
Remove this loading indicator when accessing Company cards. If we don't need it when accessing Expensify Card empty state, it shouldn't be necessary here either, as they're essentially the same page with a different graphic.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021849080892463168395
- Upwork Job ID: 1849080892463168395
- Last Price Increase: 2024-10-23
- Automatic offers:
- allgandalf | Contributor | 105194260
Issue Owner
Current Issue Owner: @getusha
Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)
@waterim is taking this one. Once they comment here, we'll assign them!
@shawnborton IDT there are really any design implications to this one, as it's just polish for the loading of this page. But LMK if anything comes to mind!
Job added to Upwork: https://www.upwork.com/jobs/~021849080892463168395
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)
Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.60-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/51360
If no regressions arise, payment will be issued on 2024-11-20. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @waterim does not require payment (Contractor)
- @getusha requires payment through NewDot Manual Requests
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [ ] [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
moving to daily since payment is coming up.
Payouts due:
- [ ] Reviewer: $250 @getusha (upwork offer - https://www.upwork.com/nx/wm/offer/104963518)
@getusha do we need a regression test?
@getusha do we need a regression test?
I don't think we do, seems a simple improvement.
cc @rlinoz
Thanks! @getusha can you please accept the Upwork offer when possible? https://www.upwork.com/nx/wm/offer/104963518
Payment Summary
- Contributor: @waterim is from an agency-contributor and not due payment
- Reviewer: @getusha owed $250 via NewDot
BugZero Checklist (@Christinadobrzyn)
- [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1849080892463168395/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
@getusha are you paid via NewDot or Upwork? Can you submit a request through NewDot if that's the best method?
@waterim Is this supposed to be fixed? I'm still seeing the same behavior.
https://github.com/user-attachments/assets/dbee0968-d9cc-473a-9249-dfc434f3dcd9
Hmm, that one was fixed for sure, someone probably updated isLoading parameter, looking now
@waterim is this it? https://github.com/Expensify/App/pull/52615
@joekaufmanexpensify probably, I took ticket to fix it, will update why its happening!
@shawnborton, @rlinoz, @waterim, @Christinadobrzyn, @getusha Eep! 4 days overdue now. Issues have feelings too...
@shawnborton, @rlinoz, @waterim, @Christinadobrzyn, @getusha Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
Just checking in on this @waterim do you have an update? It looks like the PR is still being reviewed, is that correct? https://github.com/Expensify/App/pull/52615