Expensify
[GR Phase 3] Step 2 - navigation, default data, validation logic and API call to save it
Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.bos524lch8mt
Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.
Updates: Finished with replacing mocks to the API call to get fields Added one more missed screen - AccountHolderDetails Updated the Navigation between substeps logic
Keep working on the API call for bank account creation
Today's update:
Covering edge cases, polishing the code
Waiting for the data to have a successful path with API
Today's update:
Updated request with required parameters for the successful path with API
Today's update:
Added error handling for the API create bank account request
Adding error handling for the get fields request
Today's update:
All updates and polishing are done - preparing the videos
Today's update:
Found the problem on the native side in case of error leads to inconsistent behavior Preparing the fix
Today's update:
Merged main
Found the root cause of the problem, changing the error handling approach for the failed API create bank account request
Sure, current updates:
-
Changed Confirmation substep to the Form for better API request handling
-
Facing the issue that we cannot handle the loading state with the same onyx key since it will trigger updates of the wrapper. Working now on this
Today's update:
- Problem solved, error handling updated
- Faced with changes on BE, waiting for clarification for the updated contract
Today's update:
- Adjusted request submitted with new props
- Waiting for BE fix to have the success path
Applied updated to stabilize the flow
I started recording videos, now blocked by the API error that it was before
Waiting for API updates
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
This issue has not been updated in over 15 days. @madmax330, @hungvu193, @pasyukevich eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.80-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/52812
If no regressions arise, payment will be issued on 2025-01-13. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @hungvu193 requires payment through NewDot Manual Requests
- @pasyukevich does not require payment (Contractor)
Issue is ready for payment but no BZ is assigned. @Christinadobrzyn you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Payment Summary
Upwork Job
- Reviewer: @hungvu193 owed $250 via NewDot
- Contributor: @pasyukevich is from an agency-contributor and not due payment
BugZero Checklist (@Christinadobrzyn)
- [x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [x] I have verified the payment summary above is correct
Payment summary here - https://github.com/Expensify/App/issues/50904#issuecomment-2586549625
@hungvu193 do we need a regression test for this?
Regression Test:
- Change workspace currency to EUR, GBP, CAD or AUD.
- Go to Workpsace, More feature page and Enable workflows for the workspace.
- Open workflows.
- Try to connect a bank account.
- Go to the second step - a new component should be displayed.
- The first substep validations and field lists will be received from the BE.
- For the AUD currency we should have 3 substeps (on the second upload file step, for other currencies should be skipped)
- Verify Upload picker validations (10 files limit, 5MB total, PDF/PNG/JPEG only)
- Go to the third step
- Repeat the steps and verify that the error is shown due to invalid data
Do we 👍 or 👎 ?
Regression test - https://github.com/Expensify/Expensify/issues/460902
Payment summary here - https://github.com/Expensify/App/issues/50904#issuecomment-2586549625
I think this can be closed! @hungvu193 don't forget to request payment in ND!
Hi @hungvu193 sorry to come back to this, but our QA team is testing the regression steps and isn't getting a statement upload for AUD currency (Step 7). Do you know if we no longer ask for the upload for AUD currency?
Hi @Christinadobrzyn, I've just checked that the Upload Statement screen was recently deleted in this PR. We no longer have a separate step 2 for AUD currency. cc @MrMuzyk
Hi @Christinadobrzyn. I'm curious how are they able to proceed with AUD currency in the first place, because afaik they should still be getting error message/not supported message when they try to connect bank account for AUD workspace. Currently it is not possible to test this on staging/production. This can only be accessed locally/in dev mode.
This flow is under construction for last few months and we're now close to finishing this. It will be put behind a beta flag first and we will invite QAs and designers to test our flow.
However it is true that this screen was scrapped and we're no longer asking users to upload a statement for AUD accounts.
