App icon indicating copy to clipboard operation
App copied to clipboard

[$500 Reproducible Steps] User is not showing as an option when typing `cmd+k` but not when trying `Shift+cmd+k`

Open m-natarajan opened this issue 1 year ago • 21 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Deliverable

The deliverable is to provide reliable reproduction steps for the bug. - Follow the Propose a solution for a job process to submit the steps for review”. Inc. preconditions and additional details if they’re helpful. (ie. require x beta to be enabled, must be on a Collect plan)

Version Number: 9.0.47-1 Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @mallenexpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728512692213049

Action Performed:

  1. Type shift+cmd+k to add Manan to a group chat

Expected Result:

They show as an option, since I've chatted with them before and they show when I search via cmd+k

Actual Result:

Doesn't show so can't add them to a group chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

image (1)

image

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021845848651247755910
  • Upwork Job ID: 1845848651247755910
  • Last Price Increase: 2024-10-14
Issue OwnerCurrent Issue Owner: @mallenexpensify

m-natarajan avatar Oct 11 '24 21:10 m-natarajan

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

melvin-bot[bot] avatar Oct 11 '24 21:10 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Oct 11 '24 21:10 MelvinBot

BE issue

The OpenApp API command does not return the login (email) property Screenshot 2024-10-12 at 21 15 25

NJ-2020 avatar Oct 13 '24 04:10 NJ-2020

Job added to Upwork: https://www.upwork.com/jobs/~021845848651247755910

melvin-bot[bot] avatar Oct 14 '24 15:10 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

melvin-bot[bot] avatar Oct 14 '24 15:10 melvin-bot[bot]

Thanks @NJ-2020 . I also have an issue this morning where, I got signed out over the weekend, signed in, then went to 'Find' / cmd+k (without shift) and a user I chat with frequently isn't showing, think it's the same bug? cc @allroundexperts , any thoughts here? I'm trying to suss out next steps

mallenexpensify avatar Oct 14 '24 15:10 mallenexpensify

@mallenexpensify, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 17 '24 18:10 melvin-bot[bot]

@mallenexpensify I can't reproduce this accurately. But this seems like a backend issue because the data seems to be missing. Can you reproduce this accurately?

allroundexperts avatar Oct 20 '24 21:10 allroundexperts

Thanks @allroundexperts , there's def something going with the new search, where users aren't loading when searching for them, it's not just the shift+cmd+k flow. I'm trying to think how to reproduce

mallenexpensify avatar Oct 22 '24 00:10 mallenexpensify

@mallenexpensify @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Oct 25 '24 18:10 melvin-bot[bot]

@mallenexpensify, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 25 '24 18:10 melvin-bot[bot]

@mallenexpensify, @allroundexperts 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Oct 29 '24 18:10 melvin-bot[bot]

Still kicking rocks for the time being.

I think there's a high-level issues with DMs not being returned for search or when searching to add to a group. Just tried to repro with no luck but I saw it earlier today ¯_(ツ)_/¯

mallenexpensify avatar Oct 30 '24 00:10 mallenexpensify

@mallenexpensify, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Nov 04 '24 18:11 melvin-bot[bot]

Off the next week, will address this once back.

mallenexpensify avatar Nov 06 '24 21:11 mallenexpensify

Still happening, opening it up for reliable reproduction steps. @allroundexperts and @mananjadhav , are you able to reproduce?

SnagitHelper2024 2024-11-19 14 51 19 SnagitHelper2024 2024-11-19 14 51 29

mallenexpensify avatar Nov 19 '24 22:11 mallenexpensify

@mallenexpensify No luck for me.

allroundexperts avatar Nov 24 '24 22:11 allroundexperts

Raised price for reproducible steps to see if that might help. My guess is that I have a LOT of chats and therefore some users aren't returned when searching.

mallenexpensify avatar Dec 03 '24 23:12 mallenexpensify

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 07 '24 05:12 mvtglobally

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Dec 09 '24 21:12 MelvinBot

Posted in SWM room too (and #contributor-plus, hence removing/adding Needs Reproduction)

mallenexpensify avatar Dec 10 '24 00:12 mallenexpensify

Coming from here, @Guccio163 can you comment so I can assign to you? Thx

mallenexpensify avatar Dec 10 '24 19:12 mallenexpensify

Sure, hi @mallenexpensify ! I'm Wiktor Gut from SWM agency - please assign me this issue

Guccio163 avatar Dec 10 '24 19:12 Guccio163

Thanks @Guccio163 , assigned. Leaving it a Weekly for now since you're finishing up other work first.

mallenexpensify avatar Dec 10 '24 19:12 mallenexpensify

Issue not reproducible during KI retests. (Second week)

mvtglobally avatar Dec 14 '24 04:12 mvtglobally

@Guccio163 will get to in the new year, adding them as issue owner.

mallenexpensify avatar Dec 23 '24 19:12 mallenexpensify

This issue has not been updated in over 15 days. @mallenexpensify, @allroundexperts, @Guccio163 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Jan 16 '25 09:01 melvin-bot[bot]

It seems to me that this bug no longer occurs. I ran the application from the latest main. I clicked as described inside the group chat Command+k+Shift, and everything seems to be working as it should.

sumo-slonik avatar Jan 22 '25 15:01 sumo-slonik

Thanks @sumo-slonik . I think we changed something recently where typing cmd+shift+k doesn't open "create group chat" in the right hand pane, so this bug isn't reproducible. Closing.

mallenexpensify avatar Jan 22 '25 18:01 mallenexpensify

Hi, as a sort of clarification I'm OOO from today for 2 weeks so I handed this issue to @sumo-slonik, I'm happy he solved it so quickly! Leaving this note for documentation :)

Guccio163 avatar Jan 22 '25 18:01 Guccio163