App icon indicating copy to clipboard operation
App copied to clipboard

[$500] Profile - Status dissappears before customized time

Open lanitochka17 opened this issue 1 year ago β€’ 31 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.48 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

  1. Open https://staging.new.expensify.com./
  2. Tap on "Settings"
  3. Tap on "Profie"
  4. Tap on "Status"
  5. Select emoji and type "Wow"
  6. In "Clear after" select time 1 hour ahead and tap "Save"
  7. Tap on "Back" button at the top left corner
  8. Tap on "Inbox" and return to Profile tab

Expected Result:

The status is displayed for 1 hour after being set

Actual Result:

The status dissapears immediately

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/cf5c0b1d-2cae-48fa-9896-b92766f6732f

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848860286282123001
  • Upwork Job ID: 1848860286282123001
  • Last Price Increase: 2024-12-10
  • Automatic offers:
    • dominictb | Contributor | 104742376
Issue OwnerCurrent Issue Owner: @c3024

lanitochka17 avatar Oct 11 '24 15:10 lanitochka17

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Oct 11 '24 15:10 melvin-bot[bot]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 avatar Oct 11 '24 15:10 lanitochka17

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Oct 14 '24 18:10 melvin-bot[bot]

Looking for a swap here. Otherwise, I'll need to figure out what's up with my Browserstack so I can try to repro.

strepanier03 avatar Oct 15 '24 21:10 strepanier03

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Oct 21 '24 18:10 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848860286282123001

melvin-bot[bot] avatar Oct 22 '24 22:10 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

melvin-bot[bot] avatar Oct 22 '24 22:10 melvin-bot[bot]

Was able to reproduce on v9.0.52-4 @c3024 , any idea what might be going on here?

IMG_9755B1C94030-1

mallenexpensify avatar Oct 22 '24 22:10 mallenexpensify

This looks like a backend bug.

But, I cannot reproduce this on production, staging or dev. Looks like some backend fix was deployed.

https://github.com/user-attachments/assets/6529d321-697a-4fa5-af61-4efefa1f59ae

@lanitochka17, Can you please retest this?

Thanks!

cc: @mallenexpensify

c3024 avatar Oct 23 '24 04:10 c3024

In the OP's video, the device's date is 7 days behind which causes the status to expire immediately. It's probably not worth fixing, but if you decide to, a potential solution might be for the FE to send its local time and the BE to account for this difference.

image

image

andriivitiv avatar Oct 23 '24 17:10 andriivitiv

I'm still able to reproduce on latest staging build for IOS app, v9.0.54-1

mallenexpensify avatar Oct 25 '24 18:10 mallenexpensify

@mallenexpensify @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Oct 25 '24 18:10 melvin-bot[bot]

This makes sense. I will try to repro this with changing time zone.

c3024 avatar Oct 28 '24 12:10 c3024

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Oct 29 '24 16:10 melvin-bot[bot]

@mallenexpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 31 '24 18:10 melvin-bot[bot]

No luck for me. Asked on Slack if anyone can repro this.

c3024 avatar Nov 04 '24 04:11 c3024

@c3024 I can't reproduce the original issue. But I see a similar problem:

Step:

  1. Set the local machine date to 7 previous days
  2. Set status and clear after 3 minutes compared to the current time
  3. Wait 3 minutes
  4. The status isn't cleared

DylanDylann avatar Nov 04 '24 04:11 DylanDylann

I can reproduce it. I can take over:

https://github.com/user-attachments/assets/abac5405-2cb8-47d0-bb53-5a3b72333121

cc @mallenexpensify

dominictb avatar Nov 04 '24 04:11 dominictb

πŸ“£ @dominictb πŸŽ‰ An offer has been automatically sent to your Upwork account for the Contributor role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review πŸ§‘β€πŸ’» Keep in mind: Code of Conduct | Contributing πŸ“–

melvin-bot[bot] avatar Nov 05 '24 00:11 melvin-bot[bot]

Swapped assignments to @dominictb cuz they can repro.

Added to #quality since behaviour is erratic

mallenexpensify avatar Nov 05 '24 00:11 mallenexpensify

I can only reproduce the issue when I manually update my local machine's time several days into the past. In such case, I think the behavior is expected: You sent a past "clear status after" date to the BE so it should clear the status immediately.

I took a look at @dominictb's recoding and seems like he did modify the time the way mentioned above.

Now only @mallenexpensify can reproduce it normally multiple times. Can you add a recording including all steps and export the Onyx state from Troubleshoot menu so I can take a look?

mkzie2 avatar Nov 05 '24 11:11 mkzie2

Bumped to weekly , I'm back from OOO on Nov 14th, not assigning another BZ, if one is needed please add or post in #contributor-plus to ask for one to be added, thx.

mallenexpensify avatar Nov 07 '24 00:11 mallenexpensify

@mallenexpensify Can you help take a look at https://github.com/Expensify/App/issues/50658#issuecomment-2456900085?

mkzie2 avatar Nov 28 '24 04:11 mkzie2

This issue has not been updated in over 15 days. @mallenexpensify, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Dec 02 '24 10:12 melvin-bot[bot]

I'm still able to reproduce on the latest staging build for iOS app using [email protected] Also able to reproduce on iOS Chrome with [email protected] account, check vid.

Opening back up for proposals.

https://github.com/user-attachments/assets/122f541d-5696-42ae-8d8f-fd30eaca4d1e

mallenexpensify avatar Dec 03 '24 01:12 mallenexpensify

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Dec 03 '24 16:12 melvin-bot[bot]

@mallenexpensify, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 06 '24 09:12 melvin-bot[bot]

@mallenexpensify, @dominictb 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Dec 10 '24 16:12 melvin-bot[bot]

Upwork job price has been updated to $500

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]